This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Download emsdk for web framework tests. #39268
Merged
auto-submit
merged 3 commits into
flutter:main
from
eyebrowsoffire:web_framework_tests_emsdk
Jan 31, 2023
Merged
Download emsdk for web framework tests. #39268
auto-submit
merged 3 commits into
flutter:main
from
eyebrowsoffire:web_framework_tests_emsdk
Jan 31, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for changes that will use `--local-web-sdk` instead of `--local-engine` for the web framework tests.
harryterkelsen
approved these changes
Jan 30, 2023
Contributor
harryterkelsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
auto label is removed for flutter/engine, pr: 39268, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/engine, pr: 39268, due to - The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2023
…119603) * a80741c39 Roll Skia from 3c4cd77c5e5d to fc31f43cc40a (1 revision) (flutter/engine#39278) * b7f152d50 Download emsdk for web framework tests. (flutter/engine#39268) * 72abe0e4b Remove useless variable in Canvas.drawCircle. (flutter/engine#39250)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for changes that will use
--local-web-sdkinstead of--local-enginefor the web framework tests.