This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add and reorder FAQ entries. #39106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Jan 24, 2023
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
loic-sharma
approved these changes
Jan 24, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
This is an excellent improvement, but I am still concerned that this page is overwhelming for the blog post's intended audience. I would still recommend having a dedicated docs page for the Impeller iOS preview.
chinmaygarde
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 39106, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
zanderso
approved these changes
Jan 24, 2023
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2023
…119090) * acb561092 [web] Remove dependency on 'profiling' subfolder of canvaskit. (flutter/engine#38169) * d98926c32 [Impeller] Add and reorder FAQ entries. (flutter/engine#39106)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
* [Impeller] Add and reorder FAQ entries. * Update impeller/docs/faq.md Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.