Fix potential null-pointer de-references #37678
Conversation
iskakaushik
commented
Nov 16, 2022
iskakaushik
commented
- When context is null, this is unlikely.
- When one of the components obtained from context are null, e.g, blit-pass, command-buffer, etc.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| std::shared_ptr<BlitPass> CommandBufferVK::OnCreateBlitPass() const { | ||
| FML_UNREACHABLE(); | ||
| // TODO(kaushikiska): https://github.com/flutter/flutter/issues/112649 |
There was a problem hiding this comment.
Nit: TODO(112649): [Description of issue] ?
| #include "flutter/impeller/renderer/context.h" | ||
| #include "flutter/impeller/renderer/texture.h" | ||
| #include "flutter/lib/ui/painting/image_decoder_skia.h" | ||
| #include "fml/logging.h" |
There was a problem hiding this comment.
Nit: Use flutter/fml import path like with the other imports.
iskakaushik
added
the
autosubmit
…115504) * d7f49f605 Add back tooltip to Embedder (flutter/engine#37676) * c5e6a38dd Fix potential null-point references (flutter/engine#37678)
…lutter#115504) * d7f49f605 Add back tooltip to Embedder (flutter/engine#37676) * c5e6a38dd Fix potential null-point references (flutter/engine#37678)
…lutter#115504) * d7f49f605 Add back tooltip to Embedder (flutter/engine#37676) * c5e6a38dd Fix potential null-point references (flutter/engine#37678)
3 participants
