This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[web] Update text editing test skips" #37655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
approved these changes
Nov 16, 2022
| // TODO(hterkelsen): https://github.com/flutter/flutter/issues/115327 | ||
| // TODO(hterkelsen): Firefox does not support forced-color-adjust even | ||
| // though it supports forced-colors. Safari doesn't support forced-colors | ||
| // so this isn't a problem there. |
Contributor
There was a problem hiding this comment.
Should we still run the test and just alter expectations on different browsers? The prod code will run on all browsers, it just produces different results.
Contributor
Author
There was a problem hiding this comment.
on Firefox and Safari we would be testing that 'forced-color-adjust' is not set even though we try to set it
| expect(input.style.caretColor, 'transparent'); | ||
| expect(input.style.outline, 'none'); | ||
| expect(input.style.border, 'none'); | ||
| expect(input.style.border.split(' '), contains('none')); |
Contributor
There was a problem hiding this comment.
What's the actual value? I can't tell why the split is necessary. Maybe leave a comment with an explanation?
Contributor
Author
There was a problem hiding this comment.
I changed the expectations
|
Gold has detected about 2 new digest(s) on patchset 2. |
Contributor
|
@hterkelsen is this PR still valid? |
harryterkelsen
deleted the
revert-37653-revert-37642-fix-textediting-tests
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
…131902) flutter/engine@0c1de9b...4c62dd8 2023-08-03 matanlurey@users.noreply.github.com [Impeller] Run clangd tidy, opting out in 2 cases. (flutter/engine#44351) 2023-08-03 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Update text editing test skips" (flutter/engine#37655) 2023-08-03 jason-simmons@users.noreply.github.com [Impeller] Discard invalid command buffer handles after destroying a command pool (flutter/engine#44194) 2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from bae32428c1c7 to 3b3c1a617544 (1 revision) (flutter/engine#44345) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #37642
Just skip this test on Firefox since it adds random stuff to the style.