Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

TIL this is a valid gradient, but it is used for the overflow indicator.

This is only a stopgap, to fix this for real we'd need to fallback to an entirely different approach for these gradients. Additionally, we may need to insert and beginning and end stop if the color stops do not already contain them.

@zanderso
Copy link
Member

Test failure looks related:

[ RUN      ] GeometryTest.Gradient
../../flutter/impeller/geometry/geometry_unittests.cc:1511: Failure
Expected equality of these values:
  texture_size
    Which is: 2
  1024u
    Which is: 1024
[  FAILED  ] GeometryTest.Gradient (0 ms)

@jonahwilliams
Copy link
Contributor Author

Yeah, kEhCloseEnough is actually a bit too close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants