This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Support basic back navigation in Android 13/API 33 #35678" #36051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private final OnBackInvokedCallback onBackInvokedCallback = | ||
| Build.VERSION.SDK_INT >= 33 | ||
| ? new OnBackInvokedCallback() { | ||
| @SuppressWarnings("Override") |
There was a problem hiding this comment.
Please add a TODO for removing this, explaining when it can be removed (probably best to file a Flutter issue tracking it to reference in the TODO, and reference the internal bug in that issue along with any other useful context).
There was a problem hiding this comment.
Done. Filed flutter/flutter#111295 and added TODO.
stuartmorgan-g
approved these changes
Sep 12, 2022
GaryQian
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2022
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted due to Google3 linter not properly running against API 33. This workaround is from https://b.corp.google.com/issues/243609613