This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Support basic back navigation in Android 13/API 33 #35678
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
03e2b04
Implement OnBackInvoked___
GaryQian 08971f9
Tests
GaryQian d6e915f
Docs
GaryQian 9cdeaaa
Formatting
GaryQian 87d57d3
Formatting
GaryQian 7b06ba0
Test unregister
GaryQian f1fe98b
Use getLifecycle()
GaryQian 26a55be
Lifecycle use getter
GaryQian 49ba91c
Undo lifecycle changes:
GaryQian b01082f
API gate callback
GaryQian 2e9a5ea
Formatting
GaryQian 46ee4c1
REvert some test dependency bumps
GaryQian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,6 +88,36 @@ public void flutterViewHasId() { | |
assertTrue(activity.findViewById(FlutterActivity.FLUTTER_VIEW_ID) instanceof FlutterView); | ||
} | ||
|
||
// TODO(garyq): Robolectric does not yet support android api 33 yet. Switch to a robolectric | ||
// test that directly exercises the OnBackInvoked APIs when API 33 is supported. | ||
@Test | ||
@TargetApi(33) | ||
public void itRegistersOnBackInvokedCallbackOnCreate() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we test unregistration as well? |
||
Intent intent = FlutterActivityWithReportFullyDrawn.createDefaultIntent(ctx); | ||
ActivityController<FlutterActivityWithReportFullyDrawn> activityController = | ||
Robolectric.buildActivity(FlutterActivityWithReportFullyDrawn.class, intent); | ||
FlutterActivityWithReportFullyDrawn activity = spy(activityController.get()); | ||
|
||
activity.onCreate(null); | ||
|
||
verify(activity, times(1)).registerOnBackInvokedCallback(); | ||
} | ||
|
||
// TODO(garyq): Robolectric does not yet support android api 33 yet. Switch to a robolectric | ||
// test that directly exercises the OnBackInvoked APIs when API 33 is supported. | ||
@Test | ||
@TargetApi(33) | ||
public void itUnregistersOnBackInvokedCallbackOnRelease() { | ||
Intent intent = FlutterActivityWithReportFullyDrawn.createDefaultIntent(ctx); | ||
ActivityController<FlutterActivityWithReportFullyDrawn> activityController = | ||
Robolectric.buildActivity(FlutterActivityWithReportFullyDrawn.class, intent); | ||
FlutterActivityWithReportFullyDrawn activity = spy(activityController.get()); | ||
|
||
activity.release(); | ||
|
||
verify(activity, times(1)).unregisterOnBackInvokedCallback(); | ||
} | ||
|
||
@Test | ||
public void itCreatesDefaultIntentWithExpectedDefaults() { | ||
Intent intent = FlutterActivity.createDefaultIntent(ctx); | ||
|
@@ -596,6 +626,14 @@ public void resetFullyDrawn() { | |
} | ||
} | ||
|
||
private class FlutterActivityWithMockBackInvokedHandling extends FlutterActivity { | ||
@Override | ||
public void registerOnBackInvokedCallback() {} | ||
|
||
@Override | ||
public void unregisterOnBackInvokedCallback() {} | ||
} | ||
|
||
private static final class FakeFlutterPlugin | ||
implements FlutterPlugin, | ||
ActivityAware, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should existing use of
lifecycle
change togetLifecycle()
? Otherwise it seems like we're introducing the possibility of NPEs.