Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Display List] Add runtime color source dl unittest entry #35554

Closed

Conversation

flar
Copy link
Contributor

@flar flar commented Aug 19, 2022

Double checking that this should fail on Windows, but a simple follow-on fix will get it working again.

@flar flar added the Work in progress (WIP) Not ready (yet) for review! label Aug 19, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde chinmaygarde changed the title Add runtime color source dl unittest entry [Display List] Add runtime color source dl unittest entry Aug 22, 2022
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@flar
Copy link
Contributor Author

flar commented Dec 7, 2022

Revisiting this - first to rebase to ToT to resolve conflicts and verify that it still has an issue on Windows...

@flar flar force-pushed the add-runtime-color-source-dl-unittest-entry branch from d9e4bbd to af60308 Compare December 7, 2022 19:53
@flar flar marked this pull request as draft March 30, 2023 20:12
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@chinmaygarde
Copy link
Member

Closing this as stale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests Work in progress (WIP) Not ready (yet) for review!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants