This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Upgrade Android SDK to 33 Tiramisu #35415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(artifacts are still uploading, tests will fail until uploading is complete in ~1-2hrs) |
GaryQian
added a commit
to flutter/buildroot
that referenced
this pull request
Aug 16, 2022
Changes needed for flutter/engine#35415
GaryQian
commented
Aug 18, 2022
| # We create a new temporary SDK directory because the default working directory | ||
| # tends to not update/re-download packages if they are being used. This guarantees | ||
| # a clean install of Android SDK. | ||
| temp_dir=`mktemp -d -t android_sdk` |
Contributor
Author
There was a problem hiding this comment.
Linux requires XXXX characters to randomize
Member
|
The test failures look related. Can we patch these and submit please? |
Contributor
Author
|
The failures on TOT seem to be a flaky infra failure: I'm seeing it on this PR as well, but it goes away when re-run usually |
GaryQian
added
the
autosubmit
Contributor
|
auto-submit
bot
removed
the
autosubmit
GaryQian
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades android SDK to 33 Tiramisu
Also adds a
listsubcommand to the sdk script for ease of use.