-
Notifications
You must be signed in to change notification settings - Fork 6k
[Windows] Migrate error logging to FML_LOG #35367
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Does |
|
@yaakovschectman It adds a new line to the stream automatically: Lines 75 to 77 in 643742e
|
loic-sharma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor nits
|
test-exempt: code refactor with no semantic change |
Migrates error logging from logging directly to stderr to using the FML_LOG macro with a specified log level. No additional tests since there is no semantic change to the logging (FML_LOG simply writes to stderr).
Migrates error logging from logging directly to stderr to using the
FML_LOG macro with a specified log level.
No additional tests since there is no semantic change to the logging
(FML_LOG simply writes to stderr on desktop).
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.