Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make it possible to obtain FontWeight integer value #35183

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Aug 5, 2022

Fixes flutter/flutter#109042

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from master to main August 5, 2022 14:18
@guidezpl guidezpl marked this pull request as ready for review August 5, 2022 16:16
@guidezpl guidezpl requested a review from zanderso August 5, 2022 16:16
@zanderso zanderso requested a review from jason-simmons August 5, 2022 16:18
@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2022
@auto-submit auto-submit bot merged commit eaeae8e into main Aug 5, 2022
@guidezpl guidezpl deleted the guidezpl-patch-1 branch August 5, 2022 17:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 5, 2022
* 7a536ee Roll Dart SDK from 0ab07c889f74 to 16cbbc9d5e4b (1 revision) (flutter/engine#35177)

* e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutter/engine#35120)

* d6931cc Roll Fuchsia Mac SDK from CUZLMQ1lB... to b8WQvI4f0... (flutter/engine#35179)

* c1bb5d7 Roll Dart SDK from 16cbbc9d5e4b to aada0a67f81e (1 revision) (flutter/engine#35180)

* d45c4c4 ColorFilterLayer change SkColorFilter to DLColorFilter (flutter/engine#34744)

* 1a678d2 Roll Fuchsia Linux SDK from BRTz21cLl... to kURZcohuz... (flutter/engine#35182)

* cdccc60 Roll Dart SDK from aada0a67f81e to 344a7d12b413 (1 revision) (flutter/engine#35181)

* 2c7b4f6 Update setAssetDirectory service extension to fail if provided path is invalid (flutter/engine#35178)

* ce3397f fix analysis error (flutter/engine#35187)

* eaeae8e Make it possible to obtain `FontWeight` integer value (flutter/engine#35183)

* 1f9d87d Analyze all dart code on CI (flutter/engine#35147)

* 1cf7023 [impeller] [vulkan] Support textures backed by `vk::Image`s (flutter/engine#35163)

* 57f43bd Roll Skia from 098c234c05f7 to f1245dcd35f8 (23 revisions) (flutter/engine#35189)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
…09063)

* 7a536ee Roll Dart SDK from 0ab07c889f74 to 16cbbc9d5e4b (1 revision) (flutter/engine#35177)

* e1e4a28 [Impeller] Enforce shader resource limits in impellerc (flutter/engine#35120)

* d6931cc Roll Fuchsia Mac SDK from CUZLMQ1lB... to b8WQvI4f0... (flutter/engine#35179)

* c1bb5d7 Roll Dart SDK from 16cbbc9d5e4b to aada0a67f81e (1 revision) (flutter/engine#35180)

* d45c4c4 ColorFilterLayer change SkColorFilter to DLColorFilter (flutter/engine#34744)

* 1a678d2 Roll Fuchsia Linux SDK from BRTz21cLl... to kURZcohuz... (flutter/engine#35182)

* cdccc60 Roll Dart SDK from aada0a67f81e to 344a7d12b413 (1 revision) (flutter/engine#35181)

* 2c7b4f6 Update setAssetDirectory service extension to fail if provided path is invalid (flutter/engine#35178)

* ce3397f fix analysis error (flutter/engine#35187)

* eaeae8e Make it possible to obtain `FontWeight` integer value (flutter/engine#35183)

* 1f9d87d Analyze all dart code on CI (flutter/engine#35147)

* 1cf7023 [impeller] [vulkan] Support textures backed by `vk::Image`s (flutter/engine#35163)

* 57f43bd Roll Skia from 098c234c05f7 to f1245dcd35f8 (23 revisions) (flutter/engine#35189)
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot obtain integer value from FontWeight
2 participants