-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove availability and fallbacks for iOS 11 and macOS 10.13 #34919
Conversation
d96c82a
to
7f6dbe9
Compare
@@ -17,7 +17,7 @@ | |||
constexpr char kTextPlainFormat[] = "text/plain"; | |||
const UInt32 kKeyPressClickSoundId = 1306; | |||
|
|||
} // namespaces | |||
} // namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatter wanted to touch this.
@@ -17,7 +17,7 @@ | |||
auto runner = thread->GetTaskRunner(); | |||
return runner; | |||
} | |||
} | |||
} // namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatter wanted this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I am being greedy but here goes. What are the consequences of updated to iOS 12.0 and macOS 14? MTLEvent and friends are available since then and assuming their availability would make a fallback path using host synchronization unnecessary. I've been budgeting time to add that fallback but this would be a nice win. Not super high priority though.
I'm usually more concerned about dropping hardware than OS versions since it's "free" to upgrade, but expensive to buy new hardware. Fortunately iOS 12 (2018) didn't drop any devices supported by iOS 11. iOS 11 isn't even measured in this dataset https://gs.statcounter.com/os-version-market-share/ios/mobile-tablet/worldwide (for what that's worth). macOS 10.14 Mojave also came out 2018. Mojave requires a Metal capable chip, so we would be able to drop the GL backend flutter/flutter#108304 (https://support.apple.com/en-us/HT208898). According to https://gs.statcounter.com/os-version-market-share/macos/desktop/worldwide macOS 10.13 High Sierra has about 4.5% market share. Probably more importantly, hardware manufactured 2009-2012/5 was dropped, and some users hang on to their Macs as long as possible. 10.13 High Sierra
https://support.apple.com/kb/sp765?locale=en_US vs 10.14 Mojave
https://support.apple.com/kb/SP777?locale=en_US Small overall end-user market share doesn't necessarily mean we should drop it if it also means also dropping a disproportionate number of NBU customers, and supporting "older platforms is one of our differentiators". |
macOS minimum is 10.13: flutter/buildroot#588
iOS minimum is 11: flutter/buildroot#574
@available
checks for lower versions.*_VERSION_MAX_ALLOWED
checks.NS_AVAILABLE_IOS
annotations in implementation files.Part of flutter/flutter#101959
Part of flutter/flutter#107741
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.