This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Rtree from displaylist #34809
Merged
Merged
Rtree from displaylist #34809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Contributor
Author
|
I'll note that I had to make one change to the flow/rtree code when I copied it to DisplayList as it was assuming that the RTree was created with supplementary data (see lines following 22c19): Diff of rtree.cc against display_list_rtree.cc |
Member
|
This PR LGTM once it LGT @chinmaygarde ( except for the misuse of |
Contributor
Author
|
Discovered during writing tests for the conditions that @ColdPaleLight identified - we were only applying the saveLayer image filter if there was also a clip to apply. In practice, since we have a default cull rect here, we'll always have a clip to apply anyway. |
chinmaygarde
approved these changes
Jul 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#108083
This PR simply adds a new rtree() method on DisplayList that will return an RTree implementation representing its contents, primarily for use in PlatformView embedders. No other optimizations are added that leverage the RTree.