Skip license processing for top-level source directories that are unchanged #3437
Conversation
|
Curious how big a win this is? :) |
|
For typical changes that only affect files in the flutter/ tree and do not change dart/third_party/etc, |
| ..addOption('src', help: 'The root of the engine source') | ||
| ..addOption('out', help: 'The directory where output is written') | ||
| ..addOption('golden', help: 'The directory containing golden results') | ||
| ..addFlag('release', help: 'Print output in the format used for product releases'); |
There was a problem hiding this comment.
Thanks for these flags. It makes the usage so much clearer.
|
|
||
| Stream<List<int>> _signatureStream(List files) async* { | ||
| for (RepositoryLicensedFile file in files) { | ||
| yield file.io.fullName.codeUnits; |
There was a problem hiding this comment.
Is this really necessary? I am slightly worried about case sensitivity of the file system returning different results per platform. You're comparing the file contents anyway which should catch all cases.
There was a problem hiding this comment.
This is intended to catch renaming of files (which will affect the file paths listed in the output)
There was a problem hiding this comment.
Oh. Good point. I forget the file names were also present in that list.
|
Travis didn't run it? The code LGTM but I'd like to see Travis run it first. :-) |
jason-simmons
force-pushed
the
license_hash
branch
5 times, most recently
from
39a44e4 to
257787b
Compare
|
Travis is passing now. Also modified the script to always run the full license check on the flutter tree. The goal is to avoid requiring updates to the golden signature on flutter code changes that don't affect the license output. |
jason-simmons
force-pushed
the
license_hash
branch
from
257787b to
e953ba2
Compare
jason-simmons
force-pushed
the
license_hash
branch
from
e953ba2 to
ef0b6b6
Compare
See flutter/flutter#8106