Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Handle SurfaceView in a VirtualDisplay" #34333

Closed
wants to merge 2 commits into from

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jun 27, 2022

Reverts #33599

This is most likely causing a test failure in google_maps_flutter:

06-27 08:46:06.083: I/flutter(22833): The following TestFailure was thrown running a test:
06-27 08:46:06.083: I/flutter(22833): Expected: <1100>
06-27 08:46:06.083: I/flutter(22833):   Actual: <540>
06-27 08:46:06.083: I/flutter(22833): When the exception was thrown, this was the stack:
06-27 08:46:06.083: I/flutter(22833): #4      main.<anonymous closure> (file:///tmp/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart:464:7)
06-27 08:46:06.083: I/flutter(22833): <asynchronous suspension>
06-27 08:46:06.083: I/flutter(22833): #5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:171:15)
06-27 08:46:06.083: I/flutter(22833): <asynchronous suspension>
06-27 08:46:06.083: I/flutter(22833): #6      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:841:5)
06-27 08:46:06.083: I/flutter(22833): <asynchronous suspension>
06-27 08:46:06.083: I/flutter(22833): This was caught by the test expectation on the following line:
06-27 08:46:06.083: I/flutter(22833):   file:///tmp/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart line 464
06-27 08:46:06.083: I/flutter(22833): The test description was:
06-27 08:46:06.083: I/flutter(22833):   testInitialCenterLocationAtCenter
06-27 08:46:06.084: I/flutter(22833): 

Test location: https://github.com/flutter/plugins/blob/main/packages/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart#L428

And preventing Flutter from rolling into plugins: flutter/plugins#6048.

I haven't ran this specific commit locally, but the test fails after this PR rolls into Flutter: flutter/flutter#106574

@dnfield
Copy link
Contributor

dnfield commented Jun 27, 2022

Could the failure be expected?

The patch being reverted here was known to fix some issues with how google_maps_flutter in particular did positioning.

@dnfield
Copy link
Contributor

dnfield commented Jun 28, 2022

(build failures appear to be unrelated, merging to head should resolve them)

@bparrishMines bparrishMines deleted the revert-33599-tx_rework branch June 30, 2022 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants