-
Notifications
You must be signed in to change notification settings - Fork 6k
Windows: Prevent platform thread from deadlocking during window resize #33478
Windows: Prevent platform thread from deadlocking during window resize #33478
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
17cb2ef
to
ca2d2b1
Compare
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
ca2d2b1
to
3dc7e46
Compare
I was looking at the same issue a couple of days ago and assumed that it would only occur if However, I realized that it AFAICT only occurs when attempting to resize the window programmatically using I haven't found the root cause yet but I think having a timeout for the resize condition variable is a viable safety net. |
I just tested it with the example of the linked issue (flutter/flutter#77034) and can confirm that the window gets properly moved and resized without freezing the app. |
Great, thanks a lot for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice -- Thanks!
Fixes flutter/flutter#77034
Pre-launch Checklist
writing and running engine tests.
///
).