Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

Reverts #33284

The roll to the framework is failing: flutter/flutter#103672

@zanderso zanderso merged commit 53b185d into main May 13, 2022
@zanderso zanderso deleted the revert-33284-roll-clang branch May 13, 2022 05:23
@zanderso
Copy link
Member Author

It looks like flutter_tester is failing with:

Shell: [ERROR:flutter/runtime/dart_vm_data.cc(18)] VM snapshot invalid and could not be inferred from settings.
Shell: [ERROR:flutter/runtime/dart_vm.cc(269)] Could not set up VM data to bootstrap the VM from.
Shell: [ERROR:flutter/runtime/dart_vm_lifecycle.cc(84)] Could not create Dart VM instance.
Shell: [FATAL:flutter/shell/common/shell.cc(143)] Check failed: vm. Must be able to initialize the VM.

But only on mac.

@dnfield
Copy link
Contributor

dnfield commented May 13, 2022

Seems really strange that it didn't fail on the engine CI host tests using flutter_tester...

@zanderso
Copy link
Member Author

@dnfield on CI, we only run the 'dart' test suite of run_tests.py using a host_debug_unopt build on mac, and it looks like the issue is that the Dart snapshot symbols (e.g. _kDartSnapshotData, etc.) in flutter_tester are getting dropped by the new linker in non-_unopt builds (but only on mac).

houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants