This repository was archived by the owner on Feb 25, 2025. It is now read-only.
add --fatal-warnings to dartanalyzer command line #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm! |
eseidelGoogle
added a commit
that referenced
this pull request
Jul 28, 2015
add --fatal-warnings to dartanalyzer command line
miguelfrde
pushed a commit
to miguelfrde/engine
that referenced
this pull request
Jan 7, 2020
SwiftShader is being rolled to 5d1e854.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add --fatal-warnings to the dartanalyzer command line generated by skyanalyzer
This is a quick hack to address https://github.com/domokit/sky_engine/issues/332
The command-line help for --fatal-warnings says: "treat non-type warnings as fatal". Which implies we're still not seeing all warnings.