This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace 'std::mutex' inside 'SyncSwitch' to 'fml::SharedMutex' #32773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#102144
SyncSwitch will be used for both frame rasterization on the Raster thread and texture upload on the IO thread.
But SyncSwitch uses
std::mutex
internally, which means only one thread can access it at a time. This poses a potential risk to the performance of Raster thread.This PR proposes to change the
std::mutex
to afml::SharedMutex
.Pre-launch Checklist
writing and running engine tests.
///
).