This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Standardize embedder archive name. #31693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Mar 1, 2022
| deps = [ | ||
| ":client_wrapper_windows", | ||
| "//flutter/shell/platform/common/client_wrapper:client_wrapper", | ||
| "//flutter/shell/platform/windows/client_wrapper:publish_wrapper_windows", |
Contributor
Author
There was a problem hiding this comment.
Nice catch. Rewrote it as relative import.
| ] | ||
| } | ||
|
|
||
| if (host_os == "win") { |
Member
There was a problem hiding this comment.
Is this guard needed? I'm not sure we're doing this consistently, but since this BUILD.gn file is in a Windows subdirectory, it would be more idiomatic to assert host_os == "win" at the top of the file, and then guard the places where the targets might be depended on with if (host_os == "win").
Contributor
Author
There was a problem hiding this comment.
removed the if to validate if an if (host_os == "win") will be needed.
zanderso
approved these changes
Mar 1, 2022
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 1, 2022
* e97c801 Started looking for the dart plugin registrant at runtime (flutter/engine#31418) * 9ebbc6e Standardize the embedder file name. (flutter/engine#31723) * e983ac8 Roll Skia from 1fc0c1c0f8af to 5deac304821b (2 revisions) (flutter/engine#31725) * afd334d added dart plugin registrant test executables to run_tests.py (flutter/engine#31726) * 0ff508b Standardize embedder archive name. (flutter/engine#31693) * 9c1daae Roll Fuchsia Mac SDK from qGsRXn7-D... to RIOZP5nXz... (flutter/engine#31730) * ceec638 Roll Fuchsia Linux SDK from _mwyhkd9H... to 7rB0Yrprs... (flutter/engine#31731) * 54050b4 Roll Skia from 5deac304821b to c3e7a2a00b0a (3 revisions) (flutter/engine#31732) * a5718ab Roll Dart SDK from c3e3126a598b to 34a5563af80d (6 revisions) (flutter/engine#31734)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* e97c801 Started looking for the dart plugin registrant at runtime (flutter/engine#31418) * 9ebbc6e Standardize the embedder file name. (flutter/engine#31723) * e983ac8 Roll Skia from 1fc0c1c0f8af to 5deac304821b (2 revisions) (flutter/engine#31725) * afd334d added dart plugin registrant test executables to run_tests.py (flutter/engine#31726) * 0ff508b Standardize embedder archive name. (flutter/engine#31693) * 9c1daae Roll Fuchsia Mac SDK from qGsRXn7-D... to RIOZP5nXz... (flutter/engine#31730) * ceec638 Roll Fuchsia Linux SDK from _mwyhkd9H... to 7rB0Yrprs... (flutter/engine#31731) * 54050b4 Roll Skia from 5deac304821b to c3e7a2a00b0a (3 revisions) (flutter/engine#31732) * a5718ab Roll Dart SDK from c3e3126a598b to 34a5563af80d (6 revisions) (flutter/engine#31734)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add archive targets for windows cpp client wrappers and windows flutter. These zip files were created manually in the windows host recipes.
Bug:
flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.