This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixed image generator registry usage with spawn. #31622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
image-generator-spawn
branch
from
64cd74f to
4e1ca81
Compare
gaaclarke
force-pushed
the
image-generator-spawn
branch
from
4e1ca81 to
1a0748c
Compare
gaaclarke
commented
Feb 23, 2022
Comment on lines
52
to
+54
| fml::WeakPtr<IOManager> io_manager, | ||
| fml::WeakPtr<ImageDecoder> image_decoder) const { | ||
| fml::WeakPtr<ImageDecoder> image_decoder, | ||
| fml::WeakPtr<ImageGeneratorRegistry> image_generator_registry) const { |
There was a problem hiding this comment.
It would be nice to clean this up at some point by eliminating parameters. We are almost passing in a full UIDartState::Context. I looked into it briefly and it wasn't trivial.
chinmaygarde
approved these changes
Mar 10, 2022
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#98013
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.