This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Minor refactor: move flutterViewConvertedToImageView to FlutterView from PlatformViewsController.
#31321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xZOne
force-pushed
the
task/refactor_platformview
branch
2 times, most recently
from
fd56bb4 to
08928cc
Compare
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
0xZOne
force-pushed
the
task/refactor_platformview
branch
from
08928cc to
6f6dcf8
Compare
0xZOne
changed the title
flutterViewConvertedToImageView to FlutterView from PlatformViewsController.flutterViewConvertedToImageView to FlutterView from PlatformViewsController.
0xZOne
force-pushed
the
task/refactor_platformview
branch
from
6f6dcf8 to
e58f438
Compare
… from PlatformViewsController.
0xZOne
force-pushed
the
task/refactor_platformview
branch
from
e58f438 to
835995a
Compare
|
Thank you, but we are looking into disabling FlutterImageView. See #31198. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor: move
flutterViewConvertedToImageViewto FlutterView from PlatformViewsController./cc @blasten
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.