Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused field initializing formal parameters. #30822

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Remove unused field initializing formal parameters. #30822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/web_ui/lib/src/engine/html/path/path_metrics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,13 @@ class SurfacePathMetrics extends IterableBase<ui.PathMetric>

/// Maintains a single instance of computed segments for set of PathMetric
/// objects exposed through iterator.
///
/// [resScale] controls the precision of measure when values > 1.
class _SurfacePathMeasure {
_SurfacePathMeasure(this._path, this.forceClosed, {this.resScale = 1.0})
_SurfacePathMeasure(this._path, this.forceClosed)
:
// nextContour will increment this to the zero based index.
_currentContourIndex = -1,
_pathIterator = PathIterator(_path, forceClosed);

final double resScale;
final PathRef _path;
PathIterator _pathIterator;
final List<_PathContourMeasure> _contours = <_PathContourMeasure>[];
Expand Down
6 changes: 3 additions & 3 deletions lib/web_ui/lib/src/ui/window.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,11 @@ class IsolateNameServer {
SingletonFlutterWindow get window => engine.window;

class FrameData {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is trying to implement the same API as something that is defined in the "regular" dart:ui. Since the engine doesn't use patch files, this would leave unused parameters

engine/lib/ui/window.dart

Line 874 in 93f3991

class FrameData {

So this might need an ignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, its a private constructor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

carry on

const FrameData._({this.frameNumber = -1});
const FrameData._();

const FrameData.webOnly() : frameNumber = -1;
const FrameData.webOnly();

final int frameNumber;
int get frameNumber => -1;
}

class GestureSettings {
Expand Down