Stopped creating the shell inside of a sync_switch when spawning. #29798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
shell/common/shell.cc
Outdated
| .SetIfTrue([&] { result = shell_maker(true); })); | ||
| .SetIfFalse([&isGpuDisabled] { isGpuDisabled = false; }) | ||
| .SetIfTrue([&isGpuDisabled] { isGpuDisabled = true; })); | ||
| std::unique_ptr<Shell> result = shell_maker(isGpuDisabled); |
There was a problem hiding this comment.
The shell_maker lambda can be removed and the contents can be moved here
jason-simmons
approved these changes
Nov 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2021
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
Jan 12, 2022
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
Jan 18, 2022
fbcouch
pushed a commit
to twinsunllc/engine
that referenced
this pull request
Jan 27, 2022
…utter#29798) * Stopped creating the shell inside of a sync_switch when spawning. * jason feedback
yx-mike
added a commit
to yx-mike/engine
that referenced
this pull request
May 18, 2022
…ing. (flutter#29798)" This reverts commit 4fcedfe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#93564
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.