This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland enable DisplayList by default #27892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 5, 2021
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 6, 2021
Member
|
Would these benchmark improvements be related? https://flutter-flutter-perf.skia.org/e/?begin=1628030702&end=1628814423&keys=X7cacc7b0fe7f34b957f10bc94b66b56d&requestType=0&xbaroffset=25374 |
Contributor
Author
|
That sounds like a reasonable hypothesis. It would be easy to test by checking out those revisions and then flipping the switch back and forth on the benchmark... |
Contributor
Author
|
Confirmed. I ran an A/B test with that framework commit and the associated engine commit with the flag turned off and got the following results:
|
Member
|
Nice! |
fluttergithubbot
pushed a commit
that referenced
this pull request
Aug 25, 2021
christopherfujino
added a commit
that referenced
this pull request
Sep 9, 2021
* Roll Skia cherrypicks * Revert "Reland enable DisplayList by default (#27892)" (#28308) * Started providing the GPU sync switch to Rasterizer.DrawToSurface() (#28383) Co-authored-by: Aaron Clarke <gaaclarke> * Update licenses_skia * update .ci.yaml Co-authored-by: Jim Graham <flar@google.com> Co-authored-by: ColdPaleLight <31977171+ColdPaleLight@users.noreply.github.com>
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.