This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Pass the FlutterView to app message listeners #2767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it simpler to write listeners that can be reused in multiple applications.
Contributor
|
LGTM |
Contributor
|
Should we add a call to the listeners when the FlutterView is destroyed? |
Member
Author
|
For now I'll hold off on that until we see more examples of app messaging usage. Currently I suspect that most listeners will be stateless or can safely rely on being GCed when the FlutterView goes away. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it simpler to write listeners that can be reused in multiple
applications.