This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web][felt] Fix stdout inheritance for sub-processes #27070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
mdebbar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
bdero
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 1, 2021
* 1e3fe23 Roll Skia from 76e45134b8a7 to b393c4bccd5f (1 revision) (flutter/engine#27067) * 485b25e Roll Skia from b393c4bccd5f to c9897a55650a (1 revision) (flutter/engine#27068) * 14a7ec8 Partial reland for VM tests (flutter/engine#27069) * d4431a7 Roll Skia from c9897a55650a to e1f72377e574 (3 revisions) (flutter/engine#27073) * 6e56edf [web][felt] Fix stdout inheritance for sub-processes (flutter/engine#27070) * e05cab0 Update buildroot to ignore new warnings from Clang package update (flutter/engine#27056) * 24ace61 Roll Fuchsia from 275038b to 86a2f52 (flutter/engine#27077) * 8e796bd [web] Librarify text editing files (flutter/engine#27071) * 260b94c Roll Skia from e1f72377e574 to 0734c6223cb8 (3 revisions) (flutter/engine#27078) * 6c2b052 Roll Dart SDK from 8234f00e521a to 54c79f559d23 (2 revisions) (flutter/engine#27079) * d1b56f9 Reland "fuchsia: Delete all the legacy code! (#26422)" (flutter/engine#27075)
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inheritStdoutmode for subprocesses when possible. This allows the subprocess to make better use of the terminal stdout (printing colors, printing progress on the same line, etc).q.