Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Dec 22, 2020

Cherry pick #23220

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@renyou renyou requested a review from dnfield December 22, 2020 16:30
@dnfield
Copy link
Contributor

dnfield commented Dec 22, 2020

How did this make it to a dev branch without passing tap?

@renyou
Copy link
Contributor Author

renyou commented Dec 22, 2020

How did this make it to a dev branch without passing tap?

This is a manual cherry pick from the master branch. There is another commit between #23063 and #23220 that may caused some failures in Google. So I am creating this cherrypick to go around it to unblock the roll.

@dnfield
Copy link
Contributor

dnfield commented Dec 22, 2020

Ahh ok

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renyou renyou merged commit 63a92ca into flutter:flutter-1.26-candidate.3 Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants