This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Clamp compositor surface size #22593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dreveman
approved these changes
Nov 18, 2020
dnfield
reviewed
Nov 18, 2020
dnfield
approved these changes
Nov 18, 2020
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Change LGTM.
Does it make sense to add a test covering this, since we wouldn't want it to regress in the new embedding? Or does the new embedding already have a test for this?
Contributor
Author
|
Yes a test definitely makes sense. I will do it in a follow-on CL because it looks like it will require some refactoring and this is urgent |
arbreng
force-pushed
the
fuchsia-clamp-surface
branch
from
ef190be to
2d8982f
Compare
Contributor
|
SGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fuchsia legacy embedder code doesn't clamp the sizes of surface requests from the engine, so it occasionally tried to request absurd sizes from the driver and fails. Patch this temporarily by clamping to the screen size -- which embedder API-based code already does.
Related Issues
https://b.corp.google.com/issues/173245927
https://b.corp.google.com/issues/172401700
https://b.corp.google.com/issues/173118479
https://b.corp.google.com/issues/173391703