This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Simplify API for scheduling Skia object deletions #22409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2020
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 10, 2020
* 03e750d Roll Fuchsia Linux SDK from g6EuxMthn... to DzZi2gPbF... (flutter/engine#22417) * 80e9a3f Roll Skia from 84d503b21322 to 5b8598952931 (7 revisions) (flutter/engine#22418) * 80cc0fa Roll Skia from 5b8598952931 to 02dd0ed8ce5e (1 revision) (flutter/engine#22419) * d14c4a7 Roll Skia from 02dd0ed8ce5e to fb5850f41043 (4 revisions) (flutter/engine#22420) * af185be Roll Skia from fb5850f41043 to 008d63e23dab (6 revisions) (flutter/engine#22421) * 1a13dac Simplify API for scheduling Skia object deletions (flutter/engine#22409) * 49299c3 Roll Skia from 008d63e23dab to 267826c86552 (4 revisions) (flutter/engine#22422) * 25e0829 Roll Fuchsia Mac SDK from w10eytxvc... to e-4Jm-yWa... (flutter/engine#22423) * 76e6158 Roll Skia from 267826c86552 to 88e8bb2fe2d5 (3 revisions) (flutter/engine#22424) * caf678d Move common graphics utils to //flutter/common/graphics (flutter/engine#22320)
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the need for call sites to deal with the delete queue and the timer.
Tests
Covered by existing tests. This is purely a clean-up.