This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Put the paragraph painting logic in the Paragraph class #22239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ferhatb
suggested changes
Nov 3, 2020
|
|
||
| final _CanvasPool _canvasPool; | ||
|
|
||
| html.CanvasRenderingContext2D get context => _canvasPool.context; |
Contributor
There was a problem hiding this comment.
Can you please expose a fillText() api instead. I want to make sure Context2D doesn't leak out and gets extra uses.
ferhatb
approved these changes
Nov 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the painting logic to the
Paragraphclass since it knows best about its internal structure and how to use that to paint on a canvas. This also opens up the way for having multipleParagraphimplementations that paint themselves differently without requiringBitmapCanvasto know anything about them.The same idea is applied to the generation of the DOM paragraph element. New
Paragraphimplementations won't construct the DOM element eagerly, but lazily on demand.Related Issues
flutter/flutter#55587
Tests
This change is a pure refactoring that shouldn't affect anything. Relying on existing tests to make sure there's no regressions.