This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Don't send ViewportMetrics w/ 0 DPR #21392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dnfield
reviewed
Sep 24, 2020
Contributor
|
I think you should be able to add a test for this modeled on the |
chinmaygarde
approved these changes
Sep 24, 2020
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I like Dans idea of using the optionals as ivars.
Member
|
@arbreng Can we land this now please |
arbreng
force-pushed
the
fuchsia-zero-dpr
branch
5 times, most recently
from
70b2379 to
c49d965
Compare
arbreng
force-pushed
the
fuchsia-zero-dpr
branch
from
c49d965 to
cdf6548
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Fuchsia embedder is sometimes sending 0 for the DPR when it shouldn't be. Recitfy this.
Related Issues
https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=60299
Tests
Added new test case in platform_view_unittests.