Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 11, 2020

Rolls harfbuzz to 2.7.0, which contains fixes that improve font-subset (and presumably other good things, we hope).

It is expected that this will impact golden tests that render text. /cc @renyou @mehmetf @Piinks

Fixes flutter/flutter#60325

/cc @zanderso @jonahwilliams FYI

@jason-simmons
Copy link
Member

This is not building because HarfBuzz 2.7.0 apparently requires choosing an implementation of threading primitives.

Previously we had been using a default fallback implementation (see https://fuchsia.googlesource.com/third_party/harfbuzz/+/f5c000538699a4e40649508a44f41d37035e6c35/src/hb-mutex.hh#104). But that has been removed.

Defining HAVE_PTHREAD should work for Android and Linux. I'm not sure what the best option is for Fuchsia.

@dnfield
Copy link
Contributor Author

dnfield commented Aug 11, 2020

I'm assuming based on https://fuchsia.dev/fuchsia-src/concepts/system/libc?hl=en#pthreads that this usage of pthreads on Fuchsia is OK.

@zanderso
Copy link
Member

I'm assuming based on https://fuchsia.dev/fuchsia-src/concepts/system/libc?hl=en#pthreads that this usage of pthreads on Fuchsia is OK.

Maybe @arbreng or @dreveman can confirm.

@dnfield
Copy link
Contributor Author

dnfield commented Aug 11, 2020

May be a moot point. @chinmaygarde pointed out that we don't really need harfbuzz to do any locking, so we can just tell it to not use mutexes.

@dnfield
Copy link
Contributor Author

dnfield commented Aug 11, 2020

License bot finally seems happy.

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 11, 2020
@dnfield dnfield changed the title Roll Harfbuzz to 2.7.0 (e2327f4db2f1643398d124c8c5a6d5da91e5e0fc) Roll Harfbuzz to 2.7.0 (c6ca30dc757ff86416d97d358f20080b979b80c9) Aug 11, 2020
@dnfield dnfield merged commit 8ce0972 into flutter:master Aug 11, 2020
@dnfield dnfield deleted the roll_hb branch August 11, 2020 23:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2020
This was referenced Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] FontSubset error: Font subsetting failed with exit code 255

5 participants