Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Allow access to raw zircon handle #19052

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Allow access to raw zircon handle #19052

merged 1 commit into from
Jun 16, 2020

Conversation

sanjayc77
Copy link
Contributor

Description

As part of migrating Fuchsia from legacy SceneHost/ChildView based code
to Flutter Embedder based PlatformView, we need to expose the raw zircon
handle. Since we are converting a private getter to public getter, this
does not affect any existing code.

Allow access to raw zircon handle
eb22c6c 
As part of migrating Fuchsia from legacy SceneHost/ChildView based code
to Flutter Embedder based PlatformView, we need to expose the raw zircon
handle. Since we are converting a private getter to public getter, this
does not affect any existing code.
@auto-assign auto-assign bot requested a review from iskakaushik June 16, 2020 00:23
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@iskakaushik iskakaushik merged commit d0f9ef6 into flutter:master Jun 16, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
1b17840
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
4bb6905
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
f0d929a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
7049cb4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
a930021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
fe31ce6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
1cfda08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
df0d7c8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
c374799
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
88be1a0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
8212515
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
abe381f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
fa3f15b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
0a9ecc5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
d231794
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
2f56124
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
26fa47f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
8a2a041
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
98998b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
30cb67d
@sanjayc77 sanjayc77 deleted the make-handle-public branch June 17, 2020 18:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
a3cf9fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
5250626
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
4817a6c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
dda69fe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
8a3bdc2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
fc076dc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
9211dc7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
d0f9ef6 Allow access to raw zircon handle (flutter/engine#19052)
e6014d9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arbreng arbreng arbreng approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sanjayc77 @fluttergithubbot @arbreng @iskakaushik @googlebot