This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disable the use of the API_AVAILABLE macro in Skia in iOS release builds. #17213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds. The use of this macro in C++ translation units leads to the symbol visibility being switched to default instead of hidden. This only happens in bitcode enabled builds. A toolchain upgrade will be necessary to undo this workaround.
Member
Author
|
This patch needs https://skia-review.googlesource.com/c/skia/+/277775 to be rolled in. That is currently blocked on a test lab closure because of flooding. |
Member
Author
|
Toolchain upgrade is blocked on https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=47943 |
Member
Author
|
Verified bitcode enabled release builds are fine after applying this patch. There is no presubmit for this. |
jason-simmons
approved these changes
Mar 19, 2020
tools/gn
Outdated
| gn_args['allow_deprecated_api_calls'] = True | ||
| # Bitcode enabled builds using the current version of the toolchain leak | ||
| # C++ symbols decorated with the availability attribute. Disable these | ||
| # attributess in release modes till the toolchain is updated. |
Member
Author
|
Waiting for #17214 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2020
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of this macro in C++ translation units leads to the symbol visibility
being switched to default instead of hidden. This only happens in bitcode
enabled builds. A toolchain upgrade will be necessary to undo this workaround.