Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added a log message when sharing a FlutterEngine across multiple FlutterViewControllers. #17186

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Added a log message when sharing a FlutterEngine across multiple FlutterViewControllers. #17186

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9d338d
Added a log message when sharing a FlutterEngine across multiple
gaaclarke Mar 17, 2020
e72d74e
formatter
gaaclarke Mar 17, 2020
d7fba83
updated message
gaaclarke Mar 18, 2020
9a387cb
ran formatter
gaaclarke Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ - (instancetype)initWithEngine:(FlutterEngine*)engine
self = [super initWithNibName:nibName bundle:nibBundle];
if (self) {
_viewOpaque = YES;
if (engine.viewController) {
FML_LOG(ERROR) << "The supplied FlutterEngine " << [[engine description] UTF8String]
<< " is already used with FlutterViewController instance "
<< [[engine.viewController description] UTF8String]
<< ". One instance of the FlutterEngine can only be attached to one "
"FlutterViewController at a time. Set FlutterEngine.viewController "
"to nil before attaching it to another FlutterViewController.";
}
_engine.reset([engine retain]);
_engineNeedsLaunch = NO;
_flutterView.reset([[FlutterView alloc] initWithDelegate:_engine opaque:self.isViewOpaque]);
Expand Down