This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement Path extractPath, tangent APIs #16599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryterkelsen
approved these changes
Feb 14, 2020
Contributor
harryterkelsen
left a comment
harryterkelsen
left a comment
There was a problem hiding this comment.
LGTM with nits. Mostly rubberstamping here
| class _SurfacePathMeasure { | ||
| _SurfacePathMeasure(this._path, this.forceClosed) { | ||
| _currentContourIndex = | ||
| -1; // nextContour will increment this to the zero based index. |
Contributor
There was a problem hiding this comment.
nit: put this comment on the previous line to avoid ugly formatting
|
|
||
| final List<_PathSegment> _segments = []; | ||
| // Allocate buffer large enough for returning cubic curve chop result. | ||
| static final Float32List _buffer = Float32List(4 * 2); |
Contributor
There was a problem hiding this comment.
nit: I don't think it's clearer to put 4 * 2 because I can't tell from the context why the buffer would be 2 groups of 4 rather than just 8 entries
Contributor
Author
There was a problem hiding this comment.
thx. added comment above.
| // If control point is at start or end point, this yields 0 for t = 0 and | ||
| // t = 1. In that case use the quad end points to compute tangent instead | ||
| // of derivative. | ||
| final ui.Offset tangentVector = ((t == 0 && x0 == x1 && y0 == y1) || |
Contributor
There was a problem hiding this comment.
Based on comment above, shouldn't we also be checking for t == 1 here?
Contributor
Author
There was a problem hiding this comment.
thx for spotting incorrect t == 0. Corrected.
| buffer[5] = abc2y; | ||
| } | ||
|
|
||
| double _interpolate(double startValue, double endValue, double t) |
Contributor
There was a problem hiding this comment.
nit: I'm pretty sure this already exists somewhere (lerp?)
Contributor
Author
There was a problem hiding this comment.
Added comment. lerpDouble uses num does null checks.
Contributor
Author
|
Merging on infra failure. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2020
jason-simmons
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2020
* c0549fb Roll buildroot. (flutter/engine#16613) * 8b0b649 improve surface state assert error messages (flutter/engine#16595) * cd77e78 Fix drawRRect failure when shader is specified (flutter/engine#16601) * fe63094 [web] Handle alignment correctly in Paragraph.getPositionForOffset (flutter/engine#16569) * 65d1126 [web] Fixing launching Safari. This should solve the LUCI issue (flutter/engine#16590) * f88f7df [web] Unskip tests that are already passing in Safari (flutter/engine#16567) * 594f660 [shell tests] Integrate Vulkan with Shell Tests * 400ed7c Revert "[shell tests] Integrate Vulkan with Shell Tests" * 15e7f51 Implement Path extractPath, tangent APIs (flutter/engine#16599) * 4941ff7 Remove usage of Dart_AllocateWithNativeFields from tonic (flutter/engine#16588) * bb01cb7 Roll fuchsia/sdk/core/linux-amd64 from Bmq1m... to J-_s6... (flutter/engine#16592)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
* Add pathMeasure * Implement tangetAt * add extractPath segment iterator * Implement extractPath/chopCubicAt/chopQuadAt * Wire up extractPath and add tests for cubic/quadratic * Switch to interpolate on chopCubic * addressed review comments
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit ed844fe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
flutter/flutter#41395
flutter/flutter#48386