Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@xster
Copy link
Member

@xster xster commented Jan 6, 2020

No description provided.

@xster xster requested a review from blasten January 6, 2020 23:12
@auto-assign auto-assign bot requested a review from cbracken January 6, 2020 23:12
@xster xster requested review from dnfield and removed request for cbracken January 6, 2020 23:12
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor

dnfield commented Jan 6, 2020

doc only change: all CI is red.

@xster
Copy link
Member Author

xster commented Jan 8, 2020

Cirrus isn't rechecking new luci reruns but reruns passed. And it's just changing javadocs. Merging.

@xster xster merged commit 293cd97 into flutter:master Jan 8, 2020
@xster xster deleted the fa-dep branch January 8, 2020 18:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 8, 2020
flutter/engine@f001ea2...46adf73

git log f001ea2..46adf73 --first-parent --oneline
2020-01-08 30870216+gaaclarke@users.noreply.github.com Made it so you can specify the old gen heap size. (flutter/engine#15259)
2020-01-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from gL-XG... to rTJJV... (flutter/engine#15308)
2020-01-08 xster@google.com Add a deprecation javadoc note to the old FlutterActivity (flutter/engine#15156)
2020-01-08 31859944+LongCatIsLooong@users.noreply.github.com Bump simulator version in IosUnitTests & scenario app in preparation for luci xcode 11 migration (flutter/engine#15154)
2020-01-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 91e0d7526944..f811fc331a14 (32 commits) (flutter/engine#15306)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
jmagman added a commit that referenced this pull request Jan 9, 2020
jmagman added a commit that referenced this pull request Jan 9, 2020
bkonyi pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2020
flutter/engine@f001ea2...46adf73

git log f001ea2..46adf73 --first-parent --oneline
2020-01-08 30870216+gaaclarke@users.noreply.github.com Made it so you can specify the old gen heap size. (flutter/engine#15259)
2020-01-08 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from gL-XG... to rTJJV... (flutter/engine#15308)
2020-01-08 xster@google.com Add a deprecation javadoc note to the old FlutterActivity (flutter/engine#15156)
2020-01-08 31859944+LongCatIsLooong@users.noreply.github.com Bump simulator version in IosUnitTests & scenario app in preparation for luci xcode 11 migration (flutter/engine#15154)
2020-01-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 91e0d7526944..f811fc331a14 (32 commits) (flutter/engine#15306)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2020
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants