Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} by gw280 · Pull Request #15118 · flutter/engine

gw280 · 2020-01-03T19:20:51Z

Right now we are using our own Loop and Thread implementations on flutter_runner on Fuchsia. This patch migrates us to using the built-in fml types now that they work on Fuchsia (and have unit tests running on CI).

The biggest concern I have with this is the (hopefully temporary) plumbing I've added to extract the async::Loop object from the MessageLoop through the static method FuchsiaLoopForMessageLoop on MessageLoopFuchsia. This is currently necessary because we use the Fuchsia Trace component which requires the async::Loop object to initialise.

dnfield

Most of this seems very reasonable, hoping @cbracken or @chinmaygarde can fill in some details as well.

shell/platform/fuchsia/flutter/engine.cc

dnfield · 2020-01-03T19:31:05Z

shell/platform/fuchsia/flutter/engine.h

 private:
  Delegate& delegate_;
  const std::string thread_label_;
+  flutter::ThreadHost thread_host_;


This seems like a strange class to own the thread host, but that's how we had it before I guess.

Is this migration going to help us migrate Fuchsia to the embedder API eventually, or is it completely unrelated?

@cbracken

This change should definitely move us in the direction of migrating Fuchsia to using the embedder API.

fml/platform/fuchsia/message_loop_fuchsia.cc

dnfield · 2020-01-03T19:40:55Z

CI failure on Fuchsia is an infra issue - bot update failed on one of the builders.

fml/message_loop_impl.cc

fml::{Thread,MessageLoop}

gw280 · 2020-01-07T21:22:44Z

Some updates:

Use async_get_default_dispatcher() for the trace component instead of exposing the async dispatcher object through the MessageLoopImpl
Switch to using the fml TaskObserver APIs instead of the old Fuchsia/flutter_runner-specific ones
Fix a minor issue where I was creating a new thread for the platform thread in the ThreadHost instead of using the current thread.

iskakaushik

LGTM

…fml::{Thread,MessageLoop} (flutter/engine#15118)

…read,MessageLoop} (flutter#15118)

…read,MessageLoop} (#15118)

…fml::{Thread,MessageLoop} (flutter/engine#15118)

flutter/engine@f10f03a...51a7964 git log f10f03a..51a7964 --first-parent --oneline 2020-01-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart bc9348829ef8..fc3af737c759 (2 commits) (flutter/engine#15965) 2020-01-24 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from Wc7e4... to 8Ns10... (flutter/engine#15964) 2020-01-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7e557f3e353..3ea4d5bb857d (4 commits) (flutter/engine#15963) 2020-01-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart c359b5943a52..bc9348829ef8 (1 commits) (flutter/engine#15962) 2020-01-24 gw280@google.com ensure we export the various dart snapshot symbols on Fuchsia (flutter/engine#15953) 2020-01-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 3eaae5405d37..c359b5943a52 (13 commits) (flutter/engine#15959) 2020-01-24 gw280@google.com Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (flutter/engine#15118) 2020-01-24 gw280@google.com Re-arm timer as necessary in MessageLoopFuchsia 2020-01-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia c88a3bc3f561..a7e557f3e353 (6 commits) (flutter/engine#15957) 2020-01-24 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from LAOYs... to 6_pZp... (flutter/engine#15954) 2020-01-24 zhongwuzw@qq.com Fixes FlutterCallbackInfomation leaks (flutter/engine#15089) 2020-01-24 zhongwuzw@qq.com Fixes oc leaks in platform plugin (flutter/engine#15041) 2020-01-24 jason-simmons@users.noreply.github.com Do not reset the child isolate preparer if the isolate group data already has one (flutter/engine#15952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

…fml::{Thread,MessageLoop} (flutter#15118)" This reverts commit 41e8ed0.

…fml::{Thread,MessageLoop} (#15118)" (#16277) This reverts commit 41e8ed0.

…fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903) This reverts commit a50f1ef.

…read,MessageLoop} (flutter#15118)

…fml::{Thread,MessageLoop} (flutter#15118)" (flutter#16277) This reverts commit 41e8ed0.

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#16277)" This reverts commit 4b76686.

…fml::{Thread,MessageLoop} (flutter#15118)" This reverts commit a181b0c.

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit a37eb4c.

…read,MessageLoop} (flutter#15118)

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.

gw280 requested review from dnfield and iskakaushik January 3, 2020 19:20

auto-assign bot requested a review from flar January 3, 2020 19:20

googlebot added the cla: yes label Jan 3, 2020

gw280 added the CQ+1 label Jan 3, 2020

dnfield removed the CQ+1 label Jan 3, 2020

dnfield reviewed Jan 3, 2020

View reviewed changes

gw280 requested a review from cbracken January 6, 2020 18:20

iskakaushik reviewed Jan 6, 2020

View reviewed changes

fml/message_loop_impl.cc Outdated Show resolved Hide resolved

gw280 force-pushed the gwright-fuchsia-loop branch from 739e190 to 110d157 Compare January 6, 2020 21:15

Migrate flutter_runner from flutter_runner::{Thread,Loop} to

a4408d1

fml::{Thread,MessageLoop}

gw280 force-pushed the gwright-fuchsia-loop branch from 6fa8e27 to a4408d1 Compare January 7, 2020 21:19

iskakaushik approved these changes Jan 7, 2020

View reviewed changes

review updates

cd755cd

gw280 changed the title ~~[WIP] Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop}~~ Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} Jan 7, 2020

licence file update

fbc0796

gw280 merged commit a50f1ef into flutter:master Jan 8, 2020

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020

a50f1ef Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

2fc7b6a

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 8, 2020

Roll engine 3f52888b3bcf..a50f1ef56a05 (4 commits) flutter/flutter#48372

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020

a50f1ef Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

c8f43ef

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 8, 2020

Roll engine 3f52888b3bcf..a50f1ef56a05 (4 commits) flutter/flutter#48374

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020

a50f1ef Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

6e9b775

…fml::{Thread,MessageLoop} (flutter/engine#15118)

This was referenced Jan 8, 2020

Roll engine 3f52888b3bcf..a50f1ef56a05 (4 commits) flutter/flutter#48375

Closed

Roll engine 3f52888b3bcf..a50f1ef56a05 (4 commits) flutter/flutter#48376

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020

a50f1ef Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

6498f19

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020

a50f1ef Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

308bd70

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 8, 2020

Roll engine 3f52888b3bcf..a50f1ef56a05 (4 commits) flutter/flutter#48377

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2020

a50f1ef Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

90d35e7

…fml::{Thread,MessageLoop} (flutter/engine#15118)

gw280 pushed a commit to gw280/engine that referenced this pull request Jan 23, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

70082d7

…read,MessageLoop} (flutter#15118)

gw280 pushed a commit to gw280/engine that referenced this pull request Jan 23, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

cb9932c

…read,MessageLoop} (flutter#15118)

gw280 pushed a commit to gw280/engine that referenced this pull request Jan 23, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

66a5fb6

…read,MessageLoop} (flutter#15118)

gw280 pushed a commit to gw280/engine that referenced this pull request Jan 23, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

0a61bb5

…read,MessageLoop} (flutter#15118)

gw280 pushed a commit that referenced this pull request Jan 24, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

41e8ed0

…read,MessageLoop} (#15118)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020

41e8ed0 Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

d247872

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 24, 2020

Roll engine f10f03a6c415..51a79649662f (13 commits) flutter/flutter#49434

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020

41e8ed0 Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

38e6dc8

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 24, 2020

Roll engine f10f03a6c415..51a79649662f (13 commits) flutter/flutter#49448

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020

41e8ed0 Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

dd75d0e

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 24, 2020

Roll engine f10f03a6c415..51a79649662f (13 commits) flutter/flutter#49449

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020

41e8ed0 Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

884d679

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 24, 2020

Roll engine f10f03a6c415..51a79649662f (13 commits) flutter/flutter#49450

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020

41e8ed0 Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

e07e77c

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 24, 2020

Roll engine f10f03a6c415..51a79649662f (13 commits) flutter/flutter#49451

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2020

41e8ed0 Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

ddb4787

…fml::{Thread,MessageLoop} (flutter/engine#15118)

engine-flutter-autoroll mentioned this pull request Jan 24, 2020

Roll engine f10f03a6c415..51a79649662f (13 commits) flutter/flutter#49452

Merged

gw280 pushed a commit to gw280/engine that referenced this pull request Jan 31, 2020

Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

c9b0382

…fml::{Thread,MessageLoop} (flutter#15118)" This reverts commit 41e8ed0.

gw280 pushed a commit that referenced this pull request Jan 31, 2020

Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

f5de1ac

…fml::{Thread,MessageLoop} (#15118)" (#16277) This reverts commit 41e8ed0.

NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

a37eb4c

…fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903) This reverts commit a50f1ef.

NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

a181b0c

…read,MessageLoop} (flutter#15118)

NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

4b76686

…fml::{Thread,MessageLoop} (flutter#15118)" (flutter#16277) This reverts commit 41e8ed0.

NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Revert "Migrate flutter_runner from flutter_runner::{Thread,L…

497fe1d

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#16277)" This reverts commit 4b76686.

NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to …

8654bc4

…fml::{Thread,MessageLoop} (flutter#15118)" This reverts commit a181b0c.

NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Revert "Migrate flutter_runner from flutter_runner::{Thread,L…

a65fb3e

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit a37eb4c.

filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Th…

07e0995

…read,MessageLoop} (flutter#15118)

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Apr 2, 2021

Revert "Revert "Migrate flutter_runner from flutter_runner::{Thread,L…

5a49ee4

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Apr 2, 2021

Revert "Revert "Migrate flutter_runner from flutter_runner::{Thread,L…

cc52fb1

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Apr 2, 2021

Revert "Revert "Migrate flutter_runner from flutter_runner::{Thread,L…

a21820f

…oop} to fml::{Thread,MessageLoop} (flutter#15118)" (flutter#15903)" This reverts commit 69bc783.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop}#15118

Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop}#15118
gw280 merged 3 commits intoflutter:masterfrom
gw280:gwright-fuchsia-loop

gw280 commented Jan 3, 2020

Uh oh!

dnfield left a comment

Uh oh!

Uh oh!

dnfield Jan 3, 2020

Uh oh!

iskakaushik Jan 6, 2020

Uh oh!

Uh oh!

Uh oh!

dnfield commented Jan 3, 2020

Uh oh!

Uh oh!

gw280 commented Jan 7, 2020

Uh oh!

iskakaushik left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

gw280 commented Jan 3, 2020

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dnfield Jan 3, 2020

Choose a reason for hiding this comment

Uh oh!

iskakaushik Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dnfield commented Jan 3, 2020

Uh oh!

Uh oh!

gw280 commented Jan 7, 2020

Uh oh!

iskakaushik left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants