This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for platform views in the CanvasKit backend #14263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Dec 9, 2019
| @override | ||
| void paint(PaintContext context) { | ||
| SkCanvas canvas = context.viewEmbedder.compositeEmbeddedView(viewId); | ||
| context.leafNodesCanvas = canvas; |
Contributor
There was a problem hiding this comment.
Should we remove the preceding canvas from the n-way canvas? Any operations that follow a platform view no longer apply to canvases composited under the platform view.
Contributor
Author
There was a problem hiding this comment.
As we discussed offline. This could cause problems if we don't restore from previous saves.
Contributor
Author
|
Thanks, Yegor! PTAL |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 10, 2019
flutter/engine@2805da9...12bf95f git log 2805da9..12bf95f --first-parent --oneline 2019-12-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 095d2468a075..e56cc054dbae (4 commits) (flutter/engine#14270) 2019-12-10 hterkelsen@users.noreply.github.com Add support for platform views in the CanvasKit backend (flutter/engine#14263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* Add support for platform views in the CanvasKit backend * Respond to comments * Update license file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#43783