This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disable fml_tests until they're fixed on Fuchsia #14137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Dec 4, 2019
| if (is_fuchsia) { | ||
| public_deps += [ | ||
| "$flutter_root/flow:flow_tests", | ||
| "$flutter_root/fml:fml_tests", |
Contributor
There was a problem hiding this comment.
can you file an issue to re-enable this, and comment these out with that note?
iskakaushik
approved these changes
Dec 4, 2019
Contributor
iskakaushik
left a comment
iskakaushik
left a comment
There was a problem hiding this comment.
LGTM modulo the comment.
added 2 commits
December 4, 2019 15:35
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #14087, fml_tests no longer builds on Fuchsia. Until this is fixed we need to disable it from being built.