This repository was archived by the owner on Feb 25, 2025. It is now read-only.
more tests for enabling semantics #14060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Nov 27, 2019
| }); | ||
| test('checks shouldEnableSemantics for every global event', () { | ||
| final MockSemanticsEnabler mockEnableSemantics = MockSemanticsEnabler(); | ||
| semantics().enableSemantics.enableSemantics = mockEnableSemantics; |
Contributor
There was a problem hiding this comment.
enableSemantics.enableSemantics doesn't look right. Let's rename the field (and the setter) to semanticsEnabler.
Contributor
Author
There was a problem hiding this comment.
Done.
I changed the names. I will do the refactor we discussed in a later PR.
nturgut
force-pushed
the
a11y_unit_tests
branch
from
5bfa55c to
c14252d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2019
skia-flutter-autoroll
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2019
* 29b2e91 Include uncommitted files when checking for code format issues. (flutter/engine#14035) * 7a7118d Roll src/third_party/skia 861ac61cb1a9..c96f5108df28 (10 commits) (flutter/engine#14059) * bc07e6a [web] Initial support for LineMetrics (flutter/engine#13985) * bcb8267 Revert "Do not default to downstream affinity on iOS insertText (#13852)" (flutter/engine#14053) * 4bdd15c more tests for enabling semantics (flutter/engine#14060)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit tests which would have caught: flutter/flutter#45715