Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Nov 12, 2019

The string was added in 679a436

@ghost
Copy link
Author

ghost commented Nov 12, 2019

+@mkustermann

@mkustermann mkustermann assigned ferhatb and unassigned ferhatb Nov 12, 2019
@mkustermann mkustermann requested a review from ferhatb November 12, 2019 15:58
@mkustermann
Copy link
Member

@ferhatb We just noticed this in our head-head-head setup, for which the tests are failing.

Could you roll this into flutter/flutter and fix the packages/flutter/test/painting/text_style_test.dart test?

It currently fails with:

00:35 +93 ~6 -1: /b/s/w/ir/cache/builder/flutter/packages/flutter/test/painting/text_style_test.dart: TextStyle with text direction [E]                                                                
  Expected: 'ParagraphStyle(textAlign: unspecified, textDirection: TextDirection.ltr, fontWeight: unspecified, fontStyle: unspecified, maxLines: unspecified, fontFamily: unspecified, fontSize: 14.0, height: unspecified, ellipsis: unspecified, locale: unspecified)'
    Actual: 'ParagraphStyle(textAlign: unspecified, textDirection: TextDirection.ltr, fontWeight: unspecified, fontStyle: unspecified, maxLines: unspecified, fontFamily: unspecified, fontSize: 14.0, height: unspecified, ellipsis: unspecified, locale: unspecifiedshadows: unspecified)'
     Which: is different.
            Expected: ... nspecified)
              Actual: ... nspecifiedshadows: u ...
                                    ^
             Differ at offset 249
  

@mkustermann mkustermann merged commit db23a6c into flutter:master Nov 12, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants