Revert "Guarding EAGLContext used by Flutter #13314" #13788

cyanglaz · 2019-11-12T00:44:58Z

Seems to fail some screenshot tests in the framework.


------------ TASK ------------
Task(id: 4741732661198848, parentKey: flutter/flutter/20169f0d2f6b4b4e8d9d943704b5fe034a225db4, key: 4741732661198848, commitKey: flutter/flutter/20169f0d2f6b4b4e8d9d943704b5fe034a225db4, createTimestamp: 1573492141261, startTimestamp: 1573492972002, endTimestamp: 1573493025709, name: ios_sample_catalog_generator, attempts: 2, isFlaky: false, timeoutInMinutes: 0, reason: Task failed on agent, requiredCapabilities: [mac/ios], reservedForAgentId: flutter-devicelab-mac-8, stageName: devicelab_ios, status: Failed)

------------ LOG ------------
Deleting build/ directories, if any.
2019-11-11T09:13:50.313901: Observatory listening on http://127.0.0.1:20000/
2019-11-11T09:13:52.036640: Running task.
2019-11-11T09:13:52.037426: 

══════════════════╡ ••• Checking running Dart processes ••• ╞═══════════════════

2019-11-11T09:13:52.130647: RunningProcesses{pid: 53519, commandLine: /Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart --enable-vm-service=20000 --no-pause-isolates-on-exit --disable-service-auth-codes bin/tasks/ios_sample_catalog_generator.dart --cloud-auth-token=ya29.c.Kl6wB_Vx10dXg2EACfrpjYfB6oZ3RBYwJeOxQtxLk4uIHw0Izb5TCa5qiVSZM9fX1pCvn6NrwznEXWROxoe7W5LVY1y5XdW5MUr2eKMciRqxBgFazuEoxrYx4--13hl1, creationDate: 2019-11-11 09:13:50.000}
RunningProcesses{pid: 54102, commandLine: dart bin/agent.dart ci, creationDate: 2019-10-31 11:41:15.000}
2019-11-11T09:13:52.158398: 
Executing: /Users/flutter/.cocoon/flutter/bin/cache/artifacts/libimobiledevice/idevice_id -l in /Users/flutter/.cocoon/flutter/dev/devicelab with environment {DYLD_LIBRARY_PATH: /Users/flutter/.cocoon/flutter/bin/cache/artifacts/libimobiledevice:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/usbmuxd:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/libplist:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/openssl:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/ideviceinstaller:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/ios-deploy:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/libzip}
2019-11-11T09:13:52.173456: stdout: 87b7be763fbf79fb324179b431f26198d2338da2
2019-11-11T09:13:52.174320: "/Users/flutter/.cocoon/flutter/bin/cache/artifacts/libimobiledevice/idevice_id" exit code: 0
2019-11-11T09:13:52.180373: 
Executing: /Users/flutter/.cocoon/flutter/bin/flutter packages get in /Users/flutter/.cocoon/flutter/examples/catalog
2019-11-11T09:13:53.232259: stdout: Running "flutter pub get" in catalog...                             0.5s
2019-11-11T09:13:53.416204: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 0
2019-11-11T09:13:53.417253: FLUTTER_DEVICELAB_XCODE_PROVISIONING_CONFIG variable is not defined in your
environment. Relying on automatic signing by Xcode...
2019-11-11T09:13:53.417833: 
Executing: git rev-parse HEAD in /Users/flutter/.cocoon/flutter
2019-11-11T09:13:53.427490: stdout: 20169f0d2f6b4b4e8d9d943704b5fe034a225db4
2019-11-11T09:13:53.427790: "git" exit code: 0
2019-11-11T09:13:53.428319: 
Executing: /Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart bin/sample_page.dart 20169f0d2f6b4b4e8d9d943704b5fe034a225db4 in /Users/flutter/.cocoon/flutter/examples/catalog
2019-11-11T09:13:53.665729: stdout: wrote File: '.generated/index.md'
2019-11-11T09:13:53.666372: stdout: wrote File: '.generated/animated_list.md'
2019-11-11T09:13:53.667251: stdout: wrote File: '.generated/app_bar_bottom.md'
2019-11-11T09:13:53.667757: stdout: wrote File: '.generated/basic_app_bar.md'
2019-11-11T09:13:53.668808: stdout: wrote File: '.generated/custom_a11y_traversal.md'
2019-11-11T09:13:53.669118: stdout: wrote File: '.generated/custom_semantics.md'
2019-11-11T09:13:53.669351: stdout: wrote File: '.generated/expansion_tile_sample.md'
2019-11-11T09:13:53.669680: stdout: wrote File: '.generated/tabbed_app_bar.md'
2019-11-11T09:13:53.672324: stdout: wrote File: '.generated/AnimatedList_index.md'
2019-11-11T09:13:53.672578: stdout: wrote File: '.generated/AnimatedListState_index.md'
2019-11-11T09:13:53.672892: stdout: wrote File: '.generated/AppBar_index.md'
2019-11-11T09:13:53.673136: stdout: wrote File: '.generated/PreferredSize_index.md'
2019-11-11T09:13:53.673395: stdout: wrote File: '.generated/TabBarView_index.md'
2019-11-11T09:13:53.673629: stdout: wrote File: '.generated/TabController_index.md'
2019-11-11T09:13:53.673866: stdout: wrote File: '.generated/IconButton_index.md'
2019-11-11T09:13:53.674134: stdout: wrote File: '.generated/PopupMenuButton_index.md'
2019-11-11T09:13:53.674390: stdout: wrote File: '.generated/Scaffold_index.md'
2019-11-11T09:13:53.674641: stdout: wrote File: '.generated/Semantics_index.md'
2019-11-11T09:13:53.674926: stdout: wrote File: '.generated/ExpansionTile_index.md'
2019-11-11T09:13:53.675163: stdout: wrote File: '.generated/ListView_index.md'
2019-11-11T09:13:53.675404: stdout: wrote File: '.generated/DefaultTabController_index.md'
2019-11-11T09:13:53.675640: stdout: wrote File: '.generated/TabBar_index.md'
2019-11-11T09:13:53.676320: stdout: wrote File: 'test_driver/screenshot.dart'
2019-11-11T09:13:53.676805: stdout: wrote File: 'test_driver/screenshot_test.dart'
stdout: The following entries must appear in _data/catalog/widgets.json
2019-11-11T09:13:53.676921: stdout: "sample": "AnimatedList_index"
stdout: "sample": "AnimatedListState_index"
stdout: "sample": "AppBar_index"
stdout: "sample": "PreferredSize_index"
stdout: "sample": "TabBarView_index"
stdout: "sample": "TabController_index"
stdout: "sample": "IconButton_index"
stdout: "sample": "PopupMenuButton_index"
stdout: "sample": "Scaffold_index"
stdout: "sample": "Semantics_index"
stdout: "sample": "ExpansionTile_index"
stdout: "sample": "ListView_index"
stdout: "sample": "DefaultTabController_index"
stdout: "sample": "TabBar_index"
2019-11-11T09:13:53.683611: "/Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart" exit code: 0
2019-11-11T09:13:53.683861: 
Executing: /Users/flutter/.cocoon/flutter/bin/flutter drive --target test_driver/screenshot.dart --device-id 87b7be763fbf79fb324179b431f26198d2338da2 in /Users/flutter/.cocoon/flutter/examples/catalog
2019-11-11T09:13:57.245655: stdout: Downloading ios tools...                                            2.7s
2019-11-11T09:14:00.415347: stdout: Downloading ios-profile tools...                                    2.2s
2019-11-11T09:14:14.713173: stdout: Downloading ios-release tools...                                   13.6s
2019-11-11T09:14:18.772463: stdout: Starting application: test_driver/screenshot.dart
2019-11-11T09:14:20.384745: stderr: Could not find application bundle at build/ios/iphoneos/Runner.app; have you run "flutter build ios"?
2019-11-11T09:14:21.858542: stdout: Warning: Missing build name (CFBundleShortVersionString).
2019-11-11T09:14:21.859055: stdout: Warning: Missing build number (CFBundleVersion).
2019-11-11T09:14:21.859161: stderr: Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.
2019-11-11T09:14:23.153623: stdout: Signing iOS app for device deployment using developer identity: "Apple Development: Flutter Devicelab (24273VPZX7)"
2019-11-11T09:14:35.985240: stdout: Running Xcode build...                                          
2019-11-11T09:14:35.985860: stdout: Xcode build done.                                           12.8s
2019-11-11T09:14:52.379706: stdout: Installing and launching...                                        15.3s
2019-11-11T09:14:53.754388: stdout: 00:00 �[32m+0�[0m: sample screenshots (setUpAll)�[0m
2019-11-11T09:14:53.783325: stderr: [info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:1025/uwVBEbCfsZI=/
2019-11-11T09:14:54.009953: stderr: [trace] FlutterDriver: Isolate found with number: 464943354376291
2019-11-11T09:14:54.078133: stderr: [trace] FlutterDriver: Isolate is paused at start.
2019-11-11T09:14:54.084322: stderr: [trace] FlutterDriver: Attempting to resume isolate
2019-11-11T09:14:54.092726: stderr: [trace] FlutterDriver: Waiting for service extension
2019-11-11T09:14:54.829755: stderr: [info ] FlutterDriver: Connected to Flutter application.
2019-11-11T09:14:54.834046: stdout: 00:01 �[32m+0�[0m: sample screenshots take sample screenshots�[0m
2019-11-11T09:14:56.872977: stdout: 00:03 �[32m+0�[0m�[31m -1�[0m: sample screenshots take sample screenshots �[1m�[31m[E]�[0m�[0m
2019-11-11T09:14:56.873955: stdout:   JSON-RPC error -32000: Could not capture image screenshot.
2019-11-11T09:14:56.890494: stdout:   package:json_rpc_2/src/client.dart 110:64             Client.sendRequest
stdout:   package:json_rpc_2/src/peer.dart 79:15                Peer.sendRequest
stdout:   package:flutter_driver/src/driver/driver.dart 855:53  FlutterDriver.screenshot
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
stdout:   dart:async-patch/async_patch.dart 71:23               _asyncThenWrapperHelper
stdout:   package:flutter_driver/src/driver/driver.dart         FlutterDriver.screenshot
stdout:   test_driver/screenshot_test.dart 34:47                main..
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
2019-11-11T09:14:56.890990: stdout:   dart:async-patch/async_patch.dart 71:23               _asyncThenWrapperHelper
stdout:   test_driver/screenshot_test.dart                      main..
stdout:   package:test_api/src/backend/declarer.dart 168:27     Declarer.test...
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
stdout:   dart:async-patch/async_patch.dart 71:23               _asyncThenWrapperHelper
stdout:   package:test_api/src/backend/declarer.dart            Declarer.test...
stdout:   package:test_api/src/backend/invoker.dart 250:15      Invoker.waitForOutstandingCallbacks.
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1045:19                          _CustomZone.registerCallback
stdout:   dart:async/zone.dart 962:22                           _CustomZone.bindCallbackGuarded
stdout:   dart:async/timer.dart 52:45                           new Timer
stdout:   dart:async/timer.dart 89:9                            Timer.run
stdout:   dart:async/future.dart 172:11                         new Future
stdout:   package:test_api/src/backend/invoker.dart 399:21      Invoker._onRun...
stdout: 
2019-11-11T09:14:56.892441: stdout: 00:03 �[32m+0�[0m�[31m -1�[0m: sample screenshots (tearDownAll)�[0m
2019-11-11T09:14:56.912208: stdout: 00:03 �[32m+0�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m
stdout: 
2019-11-11T09:14:56.913180: stderr: Unhandled exception:
stderr: Dummy exception to set exit code.
2019-11-11T09:14:56.913331: stderr: #0      _rootHandleUncaughtError. (dart:async/zone.dart:1112:29)
stderr: #1      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
stderr: #2      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
stderr: #3      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:391:30)
2019-11-11T09:14:56.913396: stderr: #4      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
stderr: #5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
2019-11-11T09:14:56.955219: stdout: Stopping application instance.
2019-11-11T09:14:56.959846: stderr: Driver tests failed: 255
2019-11-11T09:14:56.978778: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 255
2019-11-11T09:14:56.985854: Task failed: Executable "/Users/flutter/.cocoon/flutter/bin/flutter" failed with exit code 255.2019-11-11T09:14:56.986137: 

Stack trace:
2019-11-11T09:14:57.006147: package:flutter_devicelab/framework/utils.dart 84:3        fail
package:flutter_devicelab/framework/utils.dart 327:5       exec
===== asynchronous gap ===========================
dart:async                                                 _asyncErrorWrapperHelper
package:flutter_devicelab/framework/framework.dart         _TaskRunner._performTask.
package:stack_trace                                        Chain.capture
package:flutter_devicelab/framework/framework.dart 154:11  _TaskRunner._performTask
package:flutter_devicelab/framework/framework.dart 88:41   _TaskRunner.run

2019-11-11T09:14:57.006255: 

═══════════╡ ••• Checking running Dart processes after task... ••• ╞════════════

2019-11-11T09:14:57.027788: Cleaning up after task...
2019-11-11T09:14:57.061399: Task execution finished

Task failed with the following reason:
Task failed: Executable "/Users/flutter/.cocoon/flutter/bin/flutter" failed with exit code 255.
Deleting build/ directories, if any.
Deleting /Users/flutter/.cocoon/flutter/dev/integration_tests/external_ui/build
2019-11-11T09:22:53.224420: Observatory listening on http://127.0.0.1:20000/
2019-11-11T09:22:54.903844: Running task.
2019-11-11T09:22:54.904617: 

══════════════════╡ ••• Checking running Dart processes ••• ╞═══════════════════

2019-11-11T09:22:54.996648: RunningProcesses{pid: 41017, commandLine: /Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart --enable-vm-service=20000 --no-pause-isolates-on-exit --disable-service-auth-codes bin/tasks/ios_sample_catalog_generator.dart --cloud-auth-token=ya29.c.Kl6wB0qkzGgMShGO9vpc6FxhxDBcRAT6CA76532qfRVb2CqvUf_zpespg7_FvbYUnovK-dVdicyGggdk1Y51DI61FO6x2x5mAWDVe1f54HA_cxB2IcpP_0tkUx16_Iji, creationDate: 2019-11-11 09:22:53.000}
RunningProcesses{pid: 65308, commandLine: dart bin/agent.dart ci, creationDate: 2019-10-30 11:19:03.000}
2019-11-11T09:22:55.024375: 
Executing: /Users/flutter/.cocoon/flutter/bin/cache/artifacts/libimobiledevice/idevice_id -l in /Users/flutter/.cocoon/flutter/dev/devicelab with environment {DYLD_LIBRARY_PATH: /Users/flutter/.cocoon/flutter/bin/cache/artifacts/libimobiledevice:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/usbmuxd:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/libplist:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/openssl:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/ideviceinstaller:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/ios-deploy:/Users/flutter/.cocoon/flutter/bin/cache/artifacts/libzip}
2019-11-11T09:22:55.052883: stdout: 0f13aa3f7f48d3fa92ab08691369138b0a4b7153
2019-11-11T09:22:55.053743: "/Users/flutter/.cocoon/flutter/bin/cache/artifacts/libimobiledevice/idevice_id" exit code: 0
2019-11-11T09:22:55.059721: 
Executing: /Users/flutter/.cocoon/flutter/bin/flutter packages get in /Users/flutter/.cocoon/flutter/examples/catalog
2019-11-11T09:22:56.112859: stdout: Running "flutter pub get" in catalog...                             0.5s
2019-11-11T09:22:56.297450: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 0
2019-11-11T09:22:56.298482: FLUTTER_DEVICELAB_XCODE_PROVISIONING_CONFIG variable is not defined in your
environment. Relying on automatic signing by Xcode...
2019-11-11T09:22:56.299018: 
Executing: git rev-parse HEAD in /Users/flutter/.cocoon/flutter
2019-11-11T09:22:56.308205: stdout: 20169f0d2f6b4b4e8d9d943704b5fe034a225db4
2019-11-11T09:22:56.308497: "git" exit code: 0
2019-11-11T09:22:56.309014: 
Executing: /Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart bin/sample_page.dart 20169f0d2f6b4b4e8d9d943704b5fe034a225db4 in /Users/flutter/.cocoon/flutter/examples/catalog
2019-11-11T09:22:56.546204: stdout: wrote File: '.generated/index.md'
2019-11-11T09:22:56.547232: stdout: wrote File: '.generated/animated_list.md'
2019-11-11T09:22:56.547727: stdout: wrote File: '.generated/app_bar_bottom.md'
2019-11-11T09:22:56.548463: stdout: wrote File: '.generated/basic_app_bar.md'
2019-11-11T09:22:56.549582: stdout: wrote File: '.generated/custom_a11y_traversal.md'
2019-11-11T09:22:56.549831: stdout: wrote File: '.generated/custom_semantics.md'
2019-11-11T09:22:56.550076: stdout: wrote File: '.generated/expansion_tile_sample.md'
2019-11-11T09:22:56.550461: stdout: wrote File: '.generated/tabbed_app_bar.md'
2019-11-11T09:22:56.554274: stdout: wrote File: '.generated/AnimatedList_index.md'
2019-11-11T09:22:56.554483: stdout: wrote File: '.generated/AnimatedListState_index.md'
2019-11-11T09:22:56.554896: stdout: wrote File: '.generated/AppBar_index.md'
2019-11-11T09:22:56.555084: stdout: wrote File: '.generated/PreferredSize_index.md'
2019-11-11T09:22:56.555375: stdout: wrote File: '.generated/TabBarView_index.md'
2019-11-11T09:22:56.555570: stdout: wrote File: '.generated/TabController_index.md'
2019-11-11T09:22:56.555846: stdout: wrote File: '.generated/IconButton_index.md'
2019-11-11T09:22:56.556088: stdout: wrote File: '.generated/PopupMenuButton_index.md'
2019-11-11T09:22:56.556324: stdout: wrote File: '.generated/Scaffold_index.md'
2019-11-11T09:22:56.556581: stdout: wrote File: '.generated/Semantics_index.md'
2019-11-11T09:22:56.556850: stdout: wrote File: '.generated/ExpansionTile_index.md'
2019-11-11T09:22:56.557062: stdout: wrote File: '.generated/ListView_index.md'
2019-11-11T09:22:56.557285: stdout: wrote File: '.generated/DefaultTabController_index.md'
2019-11-11T09:22:56.557515: stdout: wrote File: '.generated/TabBar_index.md'
2019-11-11T09:22:56.558375: stdout: wrote File: 'test_driver/screenshot.dart'
2019-11-11T09:22:56.558879: stdout: wrote File: 'test_driver/screenshot_test.dart'
stdout: The following entries must appear in _data/catalog/widgets.json
stdout: "sample": "AnimatedList_index"
2019-11-11T09:22:56.558960: stdout: "sample": "AnimatedListState_index"
stdout: "sample": "AppBar_index"
stdout: "sample": "PreferredSize_index"
stdout: "sample": "TabBarView_index"
stdout: "sample": "TabController_index"
stdout: "sample": "IconButton_index"
stdout: "sample": "PopupMenuButton_index"
stdout: "sample": "Scaffold_index"
stdout: "sample": "Semantics_index"
stdout: "sample": "ExpansionTile_index"
stdout: "sample": "ListView_index"
stdout: "sample": "DefaultTabController_index"
stdout: "sample": "TabBar_index"
2019-11-11T09:22:56.565257: "/Users/flutter/.cocoon/flutter/bin/cache/dart-sdk/bin/dart" exit code: 0
2019-11-11T09:22:56.565542: 
Executing: /Users/flutter/.cocoon/flutter/bin/flutter drive --target test_driver/screenshot.dart --device-id 0f13aa3f7f48d3fa92ab08691369138b0a4b7153 in /Users/flutter/.cocoon/flutter/examples/catalog
2019-11-11T09:22:57.752749: stdout: Starting application: test_driver/screenshot.dart
2019-11-11T09:22:59.379638: stderr: Could not find application bundle at build/ios/iphoneos/Runner.app; have you run "flutter build ios"?
2019-11-11T09:23:00.447286: stdout: Warning: Missing build name (CFBundleShortVersionString).
2019-11-11T09:23:00.447817: stdout: Warning: Missing build number (CFBundleVersion).
2019-11-11T09:23:00.447983: stderr: Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.
2019-11-11T09:23:01.522187: stdout: Signing iOS app for device deployment using developer identity: "Apple Development: Flutter Devicelab (24273VPZX7)"
2019-11-11T09:23:14.221996: stdout: Running Xcode build...                                          
2019-11-11T09:23:14.230618: stdout: Xcode build done.                                           12.6s
2019-11-11T09:23:30.336049: stdout: Installing and launching...                                        14.9s
2019-11-11T09:23:31.662480: stdout: 00:00 �[32m+0�[0m: sample screenshots (setUpAll)�[0m
2019-11-11T09:23:31.690677: stderr: [info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:1026/4XeahXQPmek=/
2019-11-11T09:23:31.909770: stderr: [trace] FlutterDriver: Isolate found with number: 533646960117563
2019-11-11T09:23:31.979248: stderr: [trace] FlutterDriver: Isolate is paused at start.
2019-11-11T09:23:31.985934: stderr: [trace] FlutterDriver: Attempting to resume isolate
2019-11-11T09:23:31.995166: stderr: [trace] FlutterDriver: Waiting for service extension
2019-11-11T09:23:32.745247: stderr: [info ] FlutterDriver: Connected to Flutter application.
2019-11-11T09:23:32.748971: stdout: 00:01 �[32m+0�[0m: sample screenshots take sample screenshots�[0m
2019-11-11T09:23:34.787046: stdout: 00:03 �[32m+0�[0m�[31m -1�[0m: sample screenshots take sample screenshots �[1m�[31m[E]�[0m�[0m
2019-11-11T09:23:34.788: stdout:   JSON-RPC error -32000: Could not capture image screenshot.
2019-11-11T09:23:34.804113: stdout:   package:json_rpc_2/src/client.dart 110:64             Client.sendRequest
stdout:   package:json_rpc_2/src/peer.dart 79:15                Peer.sendRequest
stdout:   package:flutter_driver/src/driver/driver.dart 855:53  FlutterDriver.screenshot
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
stdout:   dart:async-patch/async_patch.dart 71:23               _asyncThenWrapperHelper
stdout:   package:flutter_driver/src/driver/driver.dart         FlutterDriver.screenshot
stdout:   test_driver/screenshot_test.dart 34:47                main..
2019-11-11T09:23:34.804702: stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
stdout:   dart:async-patch/async_patch.dart 71:23               _asyncThenWrapperHelper
stdout:   test_driver/screenshot_test.dart                      main..
stdout:   package:test_api/src/backend/declarer.dart 168:27     Declarer.test...
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1053:19                          _CustomZone.registerUnaryCallback
stdout:   dart:async-patch/async_patch.dart 71:23               _asyncThenWrapperHelper
stdout:   package:test_api/src/backend/declarer.dart            Declarer.test...
stdout:   package:test_api/src/backend/invoker.dart 250:15      Invoker.waitForOutstandingCallbacks.
stdout:   ===== asynchronous gap ===========================
stdout:   dart:async/zone.dart 1045:19                          _CustomZone.registerCallback
stdout:   dart:async/zone.dart 962:22                           _CustomZone.bindCallbackGuarded
2019-11-11T09:23:34.805025: stdout:   dart:async/timer.dart 52:45                           new Timer
stdout:   dart:async/timer.dart 89:9                            Timer.run
stdout:   dart:async/future.dart 172:11                         new Future
stdout:   package:test_api/src/backend/invoker.dart 399:21      Invoker._onRun...
stdout: 
2019-11-11T09:23:34.805101: stdout: 00:03 �[32m+0�[0m�[31m -1�[0m: sample screenshots (tearDownAll)�[0m
2019-11-11T09:23:34.825301: stdout: 00:03 �[32m+0�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m
stdout: 
2019-11-11T09:23:34.826096: stderr: Unhandled exception:
2019-11-11T09:23:34.826190: stderr: Dummy exception to set exit code.
stderr: #0      _rootHandleUncaughtError. (dart:async/zone.dart:1112:29)
stderr: #1      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
stderr: #2      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
2019-11-11T09:23:34.826448: stderr: #3      _Timer._runTimers (dart:isolate-patch/timer_impl.dart:391:30)
stderr: #4      _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
stderr: #5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
2019-11-11T09:23:34.868318: stdout: Stopping application instance.
2019-11-11T09:23:34.873342: stderr: Driver tests failed: 255
2019-11-11T09:23:34.892324: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 255
2019-11-11T09:23:34.899314: Task failed: Executable "/Users/flutter/.cocoon/flutter/bin/flutter" failed with exit code 255.2019-11-11T09:23:34.899577: 

Stack trace:
2019-11-11T09:23:34.915592: package:flutter_devicelab/framework/utils.dart 84:3        fail
package:flutter_devicelab/framework/utils.dart 327:5       exec
===== asynchronous gap ===========================
dart:async                                                 _asyncErrorWrapperHelper
package:flutter_devicelab/framework/framework.dart         _TaskRunner._performTask.
package:stack_trace                                        Chain.capture
package:flutter_devicelab/framework/framework.dart 154:11  _TaskRunner._performTask
package:flutter_devicelab/framework/framework.dart 88:41   _TaskRunner.run

2019-11-11T09:23:34.916420: 

═══════════╡ ••• Checking running Dart processes after task... ••• ╞════════════

2019-11-11T09:23:34.940529: Cleaning up after task...
2019-11-11T09:23:34.972745: Task execution finished

Task failed with the following reason:
Task failed: Executable "/Users/flutter/.cocoon/flutter/bin/flutter" failed with exit code 255.

This reverts commit 2dcfaae.

cyanglaz · 2019-11-12T00:46:58Z

Reverting with one conflict resolving commit. @jason-simmons please give it a go with that commit.

mklim

RSLGTM

…13314" (flutter#13759)" (flutter/engine#13788)

Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)"

2980a8d

This reverts commit 2dcfaae.

googlebot added the cla: yes label Nov 12, 2019

Merge branch 'master' into revert-13759-gl

18de119

mklim approved these changes Nov 12, 2019

View reviewed changes

jason-simmons approved these changes Nov 12, 2019

View reviewed changes

cyanglaz merged commit 6d66993 into master Nov 12, 2019

cyanglaz deleted the revert-13759-gl branch November 12, 2019 01:18

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44647

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

2849ea2

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44649

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

e9a00d2

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44650

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

b86ca15

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44652

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

fd06968

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

29c1a7e

…13314" (flutter#13759)" (flutter/engine#13788)

This was referenced Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44654

Closed

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44656

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

33386cd

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

18fe2f9

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..63e8c6275e4e (17 commits) flutter/flutter#44659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

5c77770

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..1a7bf8578d7e (19 commits) flutter/flutter#44661

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

9e94329

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

05cdac8

…13314" (flutter#13759)" (flutter/engine#13788)

This was referenced Nov 12, 2019

Roll engine 31cd2dfca22a..1a7bf8578d7e (19 commits) flutter/flutter#44664

Closed

Roll engine 31cd2dfca22a..1a7bf8578d7e (19 commits) flutter/flutter#44665

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

ce3b7b5

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44755

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

9c0a6e7

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44757

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

1076a07

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

eaa973d

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

665cad3

…13314" (flutter#13759)" (flutter/engine#13788)

This was referenced Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44762

Closed

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

3f1900b

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 12, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

a3b0e46

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..270fa824e46b (25 commits) flutter/flutter#44777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

240afcb

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

80a4bd5

…13314" (flutter#13759)" (flutter/engine#13788)

This was referenced Nov 13, 2019

Roll engine 31cd2dfca22a..429e56e97427 (29 commits) flutter/flutter#44781

Closed

Roll engine 31cd2dfca22a..429e56e97427 (29 commits) flutter/flutter#44784

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

d6bb28b

…13314" (flutter#13759)" (flutter/engine#13788)

GaryQian mentioned this pull request Nov 13, 2019

Roll engine manual 31cd2dfca22a...b358dc58fbce (39 commits) flutter/flutter#44790

Merged

cyanglaz mentioned this pull request Nov 13, 2019

RendererContextSwitch guard flutter's gl context rework. #13812

Merged

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

669ce44

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44835

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

8d8c2c5

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll mentioned this pull request Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44837

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

78e8241

…13314" (flutter#13759)" (flutter/engine#13788)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

1e4616d

…13314" (flutter#13759)" (flutter/engine#13788)

This was referenced Nov 13, 2019

Roll engine 31cd2dfca22a..198c2a7ddc2b (36 commits) flutter/flutter#44838

Closed

Roll engine 31cd2dfca22a..b358dc58fbce (39 commits) flutter/flutter#44839

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019

6d66993 Revert "Reland "Guarding EAGLContext used by Flutter flutter#…

6e8ea7e

…13314" (flutter#13759)" (flutter/engine#13788)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "Guarding EAGLContext used by Flutter #13314" #13788

Revert "Guarding EAGLContext used by Flutter #13314" #13788

Uh oh!

cyanglaz commented Nov 12, 2019

Uh oh!

cyanglaz commented Nov 12, 2019

Uh oh!

mklim left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Revert "Guarding EAGLContext used by Flutter #13314" #13788

Revert "Guarding EAGLContext used by Flutter #13314" #13788

Uh oh!

Conversation

cyanglaz commented Nov 12, 2019

Uh oh!

cyanglaz commented Nov 12, 2019

Uh oh!

mklim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants