Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move Path and PathMetrics from canvas.dart into their own files. No delta #13772

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Move Path and PathMetrics from canvas.dart into their own files. No delta #13772

merged 3 commits into from
Nov 12, 2019

Conversation

@ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Nov 9, 2019

No description provided.

harryterkelsen
harryterkelsen approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatb ferhatb merged commit 1a7bf85 into flutter:master Nov 12, 2019
@ferhatb ferhatb deleted the path_refactor branch November 12, 2019 05:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
a6b7d73 
…es. No delta (flutter/engine#13772)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
dba1d46 
…es. No delta (flutter/engine#13772)
This was referenced Nov 12, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
07108de 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
12f1396 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
049fb12 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
b189ee3 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
9ec61c1 
…es. No delta (flutter/engine#13772)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
3534a7a 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
d4d038f 
…es. No delta (flutter/engine#13772)
This was referenced Nov 12, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
ecc256e 
…es. No delta (flutter/engine#13772)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
c583580 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
36f1213 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
640f8df 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
dbb5191 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
d6b9719 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
3c627cb 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
a607e1a 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
5cf116e 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
f8fcf8d 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
809a3cf 
…es. No delta (flutter/engine#13772)
@GaryQian GaryQian mentioned this pull request Nov 13, 2019
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
52965d2 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
f28f6f9 
…es. No delta (flutter/engine#13772)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
092fabe 
…es. No delta (flutter/engine#13772)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
56cba84 
…es. No delta (flutter/engine#13772)
This was referenced Nov 13, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
@engine-flutter-autoroll
1a7bf85 Move Path and PathMetrics from canvas.dart into their own fil…
8e04e38 
…es. No delta (flutter/engine#13772)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@yjbanov yjbanov yjbanov approved these changes

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferhatb @yjbanov @harryterkelsen @googlebot