This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Implement TextStyle.shadows #13769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Nov 9, 2019
| if (shadows.length > 1) { | ||
| throw UnsupportedError('Multiple shadows on text not supported'); | ||
| } | ||
| cssStyle.textShadow = ''; |
Contributor
There was a problem hiding this comment.
Should this be assigned to _shadowListToCss(style._shadows)?
| if (style._fontFamily != previousStyle._fontFamily) { | ||
| cssStyle.fontFamily = quoteFontFamily(style._fontFamily); | ||
| } | ||
| if (style._shadows != previousStyle._shadows) { |
Contributor
There was a problem hiding this comment.
This covers the else case but not the if case.
| if (style._fontFamily != previousStyle._fontFamily) { | ||
| cssStyle.fontFamily = quoteFontFamily(style._fontFamily); | ||
| } | ||
| if (style._shadows != previousStyle._shadows) { |
Contributor
There was a problem hiding this comment.
Comparing List<ui.Shadow> using != won't work because List does not implement operator== properly. We probably need a listsEqual utility that compares lists element-wise.
Contributor
Author
There was a problem hiding this comment.
Unfortunately no ImmutableList there but TextStyle is not mutable itself, so keeping identity check.
| @required ui.TextAlign textAlign, | ||
| @required ui.TextDirection textDirection, | ||
| @required ui.Paint background, | ||
| @required List<ui.Shadow> shadows, |
Contributor
There was a problem hiding this comment.
This also needs to be added to ui.ParagraphStyle.
yjbanov
approved these changes
Nov 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
Contributor
|
This commit causes a breakage in the framework tests. They test for the exact output of ParagraphStyle.toString() in packages/flutter/test/painting/text_style_test.dart |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
This was referenced Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#44458