This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. #13319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For embedder code that is configured for both AOT and JIT mode Dart execution based on the Flutter engine being linked to, this runtime check may be used to appropriately configure the `FlutterProjectArgs`. In JIT mode execution, the kernel snapshots must be present in the Flutter assets directory specified in the `FlutterProjectArgs`. For AOT execution, the fields `vm_snapshot_data`, `vm_snapshot_instructions`, `isolate_snapshot_data` and `isolate_snapshot_instructions` (along with their size fields) must be specified in `FlutterProjectArgs`.
chinmaygarde
requested review from
franciscojma86,
jason-simmons,
jonahwilliams and
stuartmorgan-g
Member
Author
|
See flutter/flutter#43351 (comment) for a potential use case. |
Contributor
|
I could actually use this to configure the linux and windows shells as well... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2019
git@github.com:flutter/engine.git/compare/195425e04480...400e3b0 git log 195425e..400e3b0 --no-merges --oneline 2019-10-23 fmil@google.com Wires the locale provided by Fuchsia. (flutter/engine#13045) 2019-10-23 chinmaygarde@google.com Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. (flutter/engine#13319) 2019-10-23 50856934+nturgut@users.noreply.github.com [web] [test] Adding firefox install functionality to the test platform (flutter/engine#13272) 2019-10-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 32803ff74448..6863bb0930cf (7 commits) (flutter/engine#13318) 2019-10-23 bkonyi@google.com Roll src/third_party/dart 5fd6c8a3c1..b359ac0a1e (2 commits) 2019-10-23 iska.kaushik@gmail.com [recipe] Upload opt flutter_tester (flutter/engine#13311) 2019-10-23 jason-simmons@users.noreply.github.com Update the dependencies for the Fuchsia build of flutter_frontend_server (flutter/engine#13316) 2019-10-23 jmccandless@google.com NO_SUGGESTIONS keyboard flag in Android (flutter/engine#13099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/195425e04480...400e3b0 git log 195425e..400e3b0 --no-merges --oneline 2019-10-23 fmil@google.com Wires the locale provided by Fuchsia. (flutter/engine#13045) 2019-10-23 chinmaygarde@google.com Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. (flutter/engine#13319) 2019-10-23 50856934+nturgut@users.noreply.github.com [web] [test] Adding firefox install functionality to the test platform (flutter/engine#13272) 2019-10-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 32803ff74448..6863bb0930cf (7 commits) (flutter/engine#13318) 2019-10-23 bkonyi@google.com Roll src/third_party/dart 5fd6c8a3c1..b359ac0a1e (2 commits) 2019-10-23 iska.kaushik@gmail.com [recipe] Upload opt flutter_tester (flutter/engine#13311) 2019-10-23 jason-simmons@users.noreply.github.com Update the dependencies for the Fuchsia build of flutter_frontend_server (flutter/engine#13316) 2019-10-23 jmccandless@google.com NO_SUGGESTIONS keyboard flag in Android (flutter/engine#13099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For embedder code that is configured for both AOT and JIT mode Dart execution
based on the Flutter engine being linked to, this runtime check may be used to
appropriately configure the
FlutterProjectArgs. In JIT mode execution, thekernel snapshots must be present in the Flutter assets directory specified in
the
FlutterProjectArgs. For AOT execution, the fieldsvm_snapshot_data,vm_snapshot_instructions,isolate_snapshot_dataandisolate_snapshot_instructions(along with their size fields) must be specifiedin
FlutterProjectArgs.