Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
115a44d
[web] Implement drawVertices for BlendMode.src and hairline rendering
ferhatb Oct 4, 2019
c754ee6
add vertex mode
ferhatb Oct 4, 2019
10e056e
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 7, 2019
55c0794
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 7, 2019
28a645f
add test
ferhatb Oct 7, 2019
39983c9
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 9, 2019
fad22cb
add vertex mode to GLContext
ferhatb Oct 9, 2019
ede8610
Move viewport transformation into shader
ferhatb Oct 10, 2019
d3aa143
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 10, 2019
b8b06ee
Update golden revision
ferhatb Oct 10, 2019
1f86ec9
Add comments on shaders
ferhatb Oct 10, 2019
832679e
add webgl1 support for webkit
ferhatb Oct 11, 2019
e374430
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 11, 2019
d00f608
dartfmt
ferhatb Oct 11, 2019
3a2f80f
Update tests and fix hairline rendering
ferhatb Oct 11, 2019
95ce6c2
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 11, 2019
9349a0e
Added TODO for transform/drawImage
ferhatb Oct 11, 2019
d2ec77c
Implement maxDiffRate parameter for screenshot tests
ferhatb Oct 14, 2019
0cbb64b
Merge remote-tracking branch 'upstream/master' into draw_vertices2
ferhatb Oct 14, 2019
98a3eea
Update golden_tester with maxDiffRate parameter
ferhatb Oct 14, 2019
f4d0ab1
Rename maxRate
ferhatb Oct 14, 2019
41525cb
Add assert for positions.length
ferhatb Oct 14, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web_ui/dev/goldens_lock.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
repository: https://github.com/flutter/goldens.git
revision: 7efcec3e8b0bbb6748a992b23a0a89300aa323c7
revision: 686dd320f6cce6da9a7a43e3ec9c0147f39eb19d
9 changes: 5 additions & 4 deletions lib/web_ui/dev/test_platform.dart
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,13 @@ class BrowserPlatform extends PlatformPlugin {
final Map<String, dynamic> requestData = json.decode(payload);
final String filename = requestData['filename'];
final bool write = requestData['write'];
final double maxDiffRate = requestData['maxdiffrate'];
final Map<String, dynamic> region = requestData['region'];
final String result = await _diffScreenshot(filename, write, region);
final String result = await _diffScreenshot(filename, write, maxDiffRate ?? _kMaxDiffRateFailure, region);
return shelf.Response.ok(json.encode(result));
}

Future<String> _diffScreenshot(String filename, bool write, [ Map<String, dynamic> region ]) async {
Future<String> _diffScreenshot(String filename, bool write, double maxDiffRateFailure, [ Map<String, dynamic> region ]) async {
if (doUpdateScreenshotGoldens) {
write = true;
}
Expand Down Expand Up @@ -282,7 +283,7 @@ Golden file $filename did not match the image generated by the test.

final StringBuffer message = StringBuffer();
message.writeln('Golden file $filename did not match the image generated by the test.');
message.writeln(getPrintableDiffFilesInfo(diff.rate, _kMaxDiffRateFailure));
message.writeln(getPrintableDiffFilesInfo(diff.rate, maxDiffRateFailure));
message.writeln('You can view the test report in your browser by opening:');

// Cirrus cannot serve HTML pages generated by build jobs, so we
Expand Down Expand Up @@ -314,7 +315,7 @@ Golden file $filename did not match the image generated by the test.
message.writeln('Golden file: ${expectedFile.path}');
message.writeln('Actual file: ${actualFile.path}');

if (diff.rate < _kMaxDiffRateFailure) {
if (diff.rate < maxDiffRateFailure) {
// Issue a warning but do not fail the test.
print('WARNING:');
print(message);
Expand Down
Loading