This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix an objc_overrelease_during_dealloc_error. #13063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangwang1988
requested review from
dnfield and
gaaclarke
and removed request for
dnfield and
gaaclarke
gaaclarke
suggested changes
Oct 10, 2019
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Thanks again for the catch @kangwang1988. I just found out the other day my assumptions on the scoped classes are wrong, it doesn't retain in the constructor. This too is a 2 line fix, the at line 57 observer just needs to be retained, the constructor doesn't perform a retain.
Member
|
Landed #13093 which fixes this. Thanks for the find, 13093's approach is a bit more inline with the code. I was hoping to get us a nice unit test for this but I'm running into troubles getting unit testing working with these classes. If I get some more time today I have one more approach I want to try to test it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an objc_overrelease_during_dealloc_error, it is reported as below:
This issue is introduced in: 5075172fe