Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Color matrix doc #12982

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Color matrix doc #12982

merged 3 commits into from
Oct 8, 2019

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 7, 2019

These docs were a bit sparse, and based on questions coming up in chat needed some more love.

/cc @escamoteur

@jonahwilliams - am I supposed to be updating the web file too? Did we come up with a solution for keeping docs in sync there?

@dnfield dnfield requested review from Hixie and jonahwilliams October 7, 2019 21:24
@escamoteur
Copy link

escamoteur commented Oct 7, 2019 •
edited
Loading

You are making my planed blog post superfluous ;-) what does in unnormalized, 0...255, mean?

@dnfield
Copy link
Contributor Author

dnfield commented Oct 7, 2019

That doc was part of the existing docs and I'm not 100% sure I understand it well enough to explain it better. @bsalomon - could you comment on that? It'd probably be good to clarify in this.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 8, 2019

I'm going to land this on red to kick infra to use a new recipe change that should make things green.

I'll still try to circle back and clarify the unnormalized 0...255

@dnfield dnfield merged commit 4a849e0 into flutter:master Oct 8, 2019
@dnfield dnfield deleted the color_matrix_doc branch October 8, 2019 00:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2019
@engine-flutter-autoroll
4a849e0 Color matrix doc (flutter/engine#12982)
e7eda97
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 8, 2019
@engine-flutter-autoroll
Roll engine 1d62160..4a849e0 (17 commits) (#42200)
ff7e23b 
git@github.com:flutter/engine.git/compare/1d62160fdb2f...4a849e0

git log 1d62160..4a849e0 --no-merges --oneline
2019-10-08 dnfield@google.com Color matrix doc (flutter/engine#12982)
2019-10-07 jason-simmons@users.noreply.github.com Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988)
2019-10-07 bkonyi@google.com Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981)
2019-10-07 liyuqian@google.com Unblock Fuchsia roll (flutter/engine#12977)
2019-10-06 chinmaygarde@google.com Update buildroot to pull in ubsan updates. (flutter/engine#12821)
2019-10-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818)
2019-10-05 chinmaygarde@google.com Enable sanitizer build variants. (flutter/engine#12816)
2019-10-05 katelovett@google.com Revert "Adding Link SemanticsFlag (#12453)" (flutter/engine#12815)
2019-10-04 jason-simmons@users.noreply.github.com Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809)
2019-10-04 yjbanov@google.com add option for bulk-updating screenshots; update screenshots (flutter/engine#12797)
2019-10-04 dnfield@google.com unbreak unopt fuchsia (flutter/engine#12805)
2019-10-04 jason-simmons@users.noreply.github.com Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802)
2019-10-04 dnfield@google.com [flutter_runner] a11y updates, tests! (flutter/engine#12380)
2019-10-04 WATER1350@gmail.com Fix crash in copypixelbuffer (flutter/engine#10326)
2019-10-04 bkonyi@google.com Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803)
2019-10-04 katelovett@google.com Adding Link SemanticsFlag (flutter/engine#12453)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@escamoteur
Copy link

@dnfield did you get any further with the unnormalized I'm working on a blog post on this

@bsalomon
Copy link
Contributor

Sorry, I was out for two weeks and missed this. The color filter matrix stuff was created when all working colors in Skia were byte-per-component. The translation column is in this space, so if you want to add "half" to say red you'd put 128 in the upper right entry not 0.5. Maybe that's not the right API to expose through Flutter, though.

@escamoteur
Copy link

@bsalomon But 0.5 works only the fith column is 0..255

@bsalomon
Copy link
Contributor

Oh, maybe the comment is just out of date. I don't seem to be able to find the equivalent comment in the Skia code any longer. I think @reed-at-google had a series of changes in the last year that made all the matrices use floats.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 23, 2019

Yes, flutter converts it internally by dividing by 255.

I'm not 100% clear on the unnormalized part

@bsalomon
Copy link
Contributor

Ah.... unnormalized just meant that the value wasn't "normalized" to the 0 to 1 range. Maybe not the clearest nomenclature.

You might consider deprecating the current Flutter API if it expects 0..255 for the translates and adding one that takes floats. The 0..255 thing is historic baggage.

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine 1d62160..4a849e0 (17 commits) (flutter#42200)
d4ada31 
git@github.com:flutter/engine.git/compare/1d62160fdb2f...4a849e0

git log 1d62160..4a849e0 --no-merges --oneline
2019-10-08 dnfield@google.com Color matrix doc (flutter/engine#12982)
2019-10-07 jason-simmons@users.noreply.github.com Use the standard gen_snapshot target unless the platform requires host_targeting_host (flutter/engine#12988)
2019-10-07 bkonyi@google.com Roll src/third_party/dart 8413a0db0d..8ba6f7e2eb (39 commits) (flutter/engine#12981)
2019-10-07 liyuqian@google.com Unblock Fuchsia roll (flutter/engine#12977)
2019-10-06 chinmaygarde@google.com Update buildroot to pull in ubsan updates. (flutter/engine#12821)
2019-10-05 skia-flutter-autoroll@skia.org Roll src/third_party/skia 95edac1c9a4a..4c82a9fc83a5 (13 commits) (flutter/engine#12818)
2019-10-05 chinmaygarde@google.com Enable sanitizer build variants. (flutter/engine#12816)
2019-10-05 katelovett@google.com Revert "Adding Link SemanticsFlag (flutter#12453)" (flutter/engine#12815)
2019-10-04 jason-simmons@users.noreply.github.com Use the x64 host toolchain for x86 target gen_snapshot only on Linux (flutter/engine#12809)
2019-10-04 yjbanov@google.com add option for bulk-updating screenshots; update screenshots (flutter/engine#12797)
2019-10-04 dnfield@google.com unbreak unopt fuchsia (flutter/engine#12805)
2019-10-04 jason-simmons@users.noreply.github.com Build gen_snapshot with a 64-bit host toolchain even if the target platform is 32-bit (flutter/engine#12802)
2019-10-04 dnfield@google.com [flutter_runner] a11y updates, tests! (flutter/engine#12380)
2019-10-04 WATER1350@gmail.com Fix crash in copypixelbuffer (flutter/engine#10326)
2019-10-04 bkonyi@google.com Roll src/third_party/dart d6c6d12ebf..8413a0db0d (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from JyZWz... to kwa2O... (flutter/engine#12803)
2019-10-04 katelovett@google.com Adding Link SemanticsFlag (flutter/engine#12453)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@Hixie Hixie Awaiting requested review from Hixie

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnfield @escamoteur @bsalomon @chinmaygarde @googlebot